[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 29 20:45:03 UTC 2012 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800526

Michael Scherer <misc at zarb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Michael Scherer <misc at zarb.org> 2012-03-29 16:45:02 EDT ---

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.


==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint seahorse-sharing-3.4.0-1.fc18.i686.rpm

seahorse-sharing.i686: W: obsolete-not-provided seahorse
seahorse-sharing.i686: W: non-conffile-in-etc
/etc/xdg/autostart/seahorse-sharing.desktop
seahorse-sharing.i686: E: incorrect-fsf-address
/usr/share/doc/seahorse-sharing-3.4.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 2 warnings.


rpmlint seahorse-sharing-debuginfo-3.4.0-1.fc18.i686.rpm

seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-hkp-server.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-sharing.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-daemon.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-unix-signal.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/libegg/eggdesktopfile.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-unix-signal.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-daemon.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/libegg/eggdesktopfile.c
1 packages and 0 specfiles checked; 8 errors, 0 warnings.


rpmlint seahorse-sharing-3.4.0-1.fc18.src.rpm

seahorse-sharing.src:11: W: unversioned-explicit-provides bundled(egglib)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/tmp/800526/seahorse-sharing-3.4.0.tar.xz :
  MD5SUM this package     : 6f5dac5fbf4ef064ccb48469663b5fe2
  MD5SUM upstream package : 6f5dac5fbf4ef064ccb48469663b5fe2

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Rpmlint output is silent.

rpmlint seahorse-sharing-3.4.0-1.fc18.i686.rpm

seahorse-sharing.i686: W: obsolete-not-provided seahorse
seahorse-sharing.i686: W: non-conffile-in-etc
/etc/xdg/autostart/seahorse-sharing.desktop
seahorse-sharing.i686: E: incorrect-fsf-address
/usr/share/doc/seahorse-sharing-3.4.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 2 warnings.


rpmlint seahorse-sharing-debuginfo-3.4.0-1.fc18.i686.rpm

seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-hkp-server.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-sharing.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-daemon.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-unix-signal.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/libegg/eggdesktopfile.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-unix-signal.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-daemon.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/libegg/eggdesktopfile.c
1 packages and 0 specfiles checked; 8 errors, 0 warnings.


rpmlint seahorse-sharing-3.4.0-1.fc18.src.rpm

seahorse-sharing.src:11: W: unversioned-explicit-provides bundled(egglib)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint


Generated by fedora-review 0.1.3
External plugins:


So the rpmlint warning are either normal ( ie, obsolete without conflict is the
thing to do, I think ), or something that should be corrected upstream ( the
FSF address ), or just wrong ( ie, /etc/xdg/autostart, maybe this should be
moved to /usr/lib, like what is done with systemd ).

So the package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list