[Bug 783825] Review Request: suil - A lightweight C library for loading and wrapping LV2 plugin UIs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783825

--- Comment #25 from Brendan Jones <brendan.jones.it at gmail.com> 2012-03-29 23:39:04 EDT ---
(In reply to comment #24)
> My comments:
> * The license tag should be MIT:
>   
> https://fedoraproject.org/wiki/Licensing/MIT#Old_Style_with_legal_disclaimer_2

OK as the ISC license is an MIT derivative and is word for word the same as
your link I will change the license (https://www.isc.org/software/license)
Both are good licenses, this package will report ISC when using licensecheck
however.

> 
> * The description of the gtk subpackage is the same as the qt package.
> Copy/paste error?
> At this point I want to question the rationale of splitting the package into
> subpackages. Why do we need this? If we really need this please make the
> descriptions more descriptive, as
>    "This package contains the Qt library for %{name}."
> is ambiguous for such a package.

I'm happy to question this again. If I have this correctly, any host which is
build against suil will require both libraries. It won't know at runtime what
toolkits a plugin may use until its asked to instantiate it, and the way the
package is split at the moment we run the risk of a missing a runtime 
dependency. The only advantage I see at the moment is that it would be possible
to have a Qt host that only loads Qt plugins but I think that's inviting
trouble without having any Gtk libraries (in which case the user decides which
suil library they have to install manually - yeuch).
Is that your take? I think we should probably move them back into the main
package

> 
> ! I need to make a note that in Fedora the Qt4 packages usually use
>    BuildRequires:  qt4-devel
> 
> - The rpmlints
>    suil-gtk.x86_64: W: no-documentation
>    suil-qt.x86_64: W: no-documentation
>    suil.x86_64: W: spelling-error %description -l en_US toolkits -> toolkit,
> tool kits, tool-kits
>    suil.x86_64: W: spelling-error %description -l en_US runtime -> run time,
> run-time, rudiment
> can be ignored

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.