[Bug 808258] Review Request: python-sh - Python module to simplify calling shell commands

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=808258

Michael Scherer <misc at zarb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc at zarb.org
               Flag|                            |fedora-review?

--- Comment #1 from Michael Scherer <misc at zarb.org> 2012-03-30 11:09:48 EDT ---
Hi,

first, BuildRoot is no longer needed, unless you target EPEL 5

so does :
%defattr(-,root,root,-) 
%clean with rm -Rf
rm -Rf in %install 

( cf https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag )

* using %{python_sitelib} mean that the directory will be owned by this rpm,
and that should be avoid.

* BuildRequires:  python-devel python-setuptools

it is easier to review patch with 2 lines for each buildRequires ( IMHO )

and you should explicitely say if this is for python 2 or 3 (
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires ), due to the
current transition.

* there seems to be some test to run, but they are not run by %check, any
reason ? 

* As a side note, I think you could try to convince upstream of pushing tarball
to pypi as well, since having a tarball called "0.95" is rather ugly ( and I
think this may be against the guideline :
https://fedoraproject.org/wiki/Packaging:SourceURL ).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.