[Bug 808336] Review Request: dia-gnomeDIAicons - Beautiful icon set for dia diagram editor

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 30 16:13:26 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=808336

Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Peter Lemenkov <lemenkov at gmail.com> 2012-03-30 12:13:26 EDT ---
(In reply to comment #6)
> Is this OK now?
> 
> http://arthurbuliva.com/sites/default/files/dia-gnomeDIAicons.spec

Almost. I see only two remaining issues.

* You accidentally changed previously perfectly valid "Url" field. Its current
value should go to the Source0 field.

* License still GPLv2+. It must be GPL+.

Both of these are easy-to fix issues so, please, fix them and this package is


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list