[Bug 815135] Review Request: atf - Automated Testing Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815135

--- Comment #2 from Michel Alexandre Salim <michel+fdr at sylvestre.me> 2012-05-01 00:33:27 EDT ---
I've tested the generated against lutok, and atf-run works fine if
libatf-c++-devel is installed when lutok is configured and built.

One change needs to be made to the packaging -- it's generally fine if
subpackages do not have documentation, if they depend on the main package --
but in your case, since the libatf-* subpackages are not dependent on atf, some
of them need to include at least the license text (COPYING). Basically any
installable subset of atf needs to carry the license text.

Looks like adding the LICENSE text to libatf-c is sufficient since all the
other subpackages depend on it eventually.

* TODO Review [90%]
  - [X] Names [2/2]
    - [X] Package name
    - [X] Spec name
  - [X] Package version [2/2]
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
    - [X] Version number
   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
    - [X] Release tag
   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
  
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
  - [X] Meets
[[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
  - [X] Source files match upstream
  $ sha256sum atf-0.15.tar.gz ../SOURCES/atf-0.15.tar.gz 
  0c7242a107c7e308feed8fac45a194a6f6c8d90283add576cfc3dab0fcd61b2b 
atf-0.15.tar.gz
  0c7242a107c7e308feed8fac45a194a6f6c8d90283add576cfc3dab0fcd61b2b 
../SOURCES/atf-0.15.tar.gz

  - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No
bundled libraries]]
  - [X] License [4/4]
    - [X] License is Fedora-approved
    - [X] No licensing conflict
    - [X] License field accurate
    - [X] License included iff packaged by upstream
  - [-] rpmlint [1/2]
    - [X] on src.rpm
      ✗ rpmlint ./atf-0.15-1.fc17.src.rpm 
      1 packages and 0 specfiles checked; 0 errors, 0 warnings.
    - [ ] on x86_64.rpm
      ✗ rpmlint ~/Downloads/*atf*.rpm
      atf.x86_64: W: devel-file-in-non-devel-package /usr/bin/atf-config
      libatf-c.x86_64: W: no-documentation
      libatf-c++.x86_64: W: no-documentation
      8 packages and 0 specfiles checked; 0 errors, 3 warnings.

      Note: since libatf-c and libatf-c++ do not require the base package,
      you must at least include the COPYING file as documentation

  - [X] Language & locale [2/2]
    - [X] Spec in US English
    - [X] Spec legible
  - [X] Build [3/3]
    - [X] Koji results
      http://koji.fedoraproject.org/koji/taskinfo?taskID=4038205
    - [X] BRs complete
    - [X] Directory ownership
  - [X] Spec inspection [8/8]
    - [X] ldconfig for libraries
    - [X] No duplicate files
    - [X] File permissions
    - [X] Filenames must be UTF-8
    - [X] no BuildRoot
([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if
targeting RHEL5]])
    - [X] Macro usage consistent
    - [X] Documentation [1/1]
      - [X] %doc files are non-essential
    - [X] Development [4/4]
      - [X] Headers in -devel
      - [X] If versioned .so's, unversioned in -devel
      - [X] -devel, -static requires main
      - [X] No .la

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.