[Bug 809114] Review Request: novacom-server - Utility to connect to WebOS devices

Mon May 7 11:32:08 UTC 2012

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=809114

Mohamed El Morabity <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #21 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2012-05-07 07:32:07 EDT ---
Sorry, I was just waiting that the logging issue was solved. Here is the
review:

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated

==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[ ]: MUST Package is not relocatable.

==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint novacom-server-1.1.0-0.5.rc1.fc18.src.rpm

novacom-server.src: W: spelling-error %description -l en_US systemctl ->
systemic
novacom-server.src: W: spelling-error %description -l en_US novacomd -> Donovan
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint novacom-server-1.1.0-0.5.rc1.fc18.i686.rpm

novacom-server.i686: W: spelling-error %description -l en_US systemctl ->
systemic
novacom-server.i686: W: only-non-binary-in-usr-lib
novacom-server.i686: W: no-manual-page-for-binary novacomd
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

rpmlint novacom-server-debuginfo-1.1.0-0.5.rc1.fc18.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.
>>> Can be safely ignored

[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/mohamed/809114/openwebos-novacomd-submissions-119.1-0-ge77d336.tar.gz :
  MD5SUM this package     : 9cdb4ee0de1942100a9000506889dfb2
  MD5SUM upstream package : 9cdb4ee0de1942100a9000506889dfb2

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[ ]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: SHOULD Scriptlets must be sane, if used.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source0:
     https://github.com/openwebos/novacomd/tarball/versions/1.1.0-rc1
     /openwebos-novacomd-submissions-119.1-0-ge77d336.tar.gz (openwebos-
     novacomd-submissions-119.1-0-ge77d336.tar.gz) Source1: novacomd.service
     (novacomd.service) Source2: config-novacomd (config-novacomd) Patch0:
     0001-Use-usb_bulk_-read-write-instead-of-homemade-handler.patch (0001
     -Use-usb_bulk_-read-write-instead-of-homemade-handler.patch) Patch1:
     novacomd_add_cflags.patch (novacomd_add_cflags.patch) Patch2: novacomd-
     quiet-logging.patch (novacomd-quiet-logging.patch)
>>> Not a blocker
[x]: SHOULD SourceX is a working URL.
[ ]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[ ]: SHOULD %check is present and all tests pass.
[!]: SHOULD Packages should try to preserve timestamps of original installed
     files.
>>> See below
[x]: SHOULD Spec use %global instead of %define.

Issues:
[x]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean is needed only if supporting EPEL
See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
See: None
[ ]: MUST Rpmlint output is silent.

rpmlint novacom-server-1.1.0-0.5.rc1.fc18.src.rpm

novacom-server.src: W: spelling-error %description -l en_US systemctl ->
systemic
novacom-server.src: W: spelling-error %description -l en_US novacomd -> Donovan
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint novacom-server-1.1.0-0.5.rc1.fc18.i686.rpm

novacom-server.i686: W: spelling-error %description -l en_US systemctl ->
systemic
novacom-server.i686: W: only-non-binary-in-usr-lib
novacom-server.i686: W: no-manual-page-for-binary novacomd
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
>>> Can be ignored safely.

rpmlint novacom-server-debuginfo-1.1.0-0.5.rc1.fc18.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

----

Some (last!) comments, according to the above tests:
- you should add the -p flag to the install command to preserve timestamps;
- the sources embed parts of zlib (see in src/lib/cksum/), fortunately neither
used nor called by novacomd. You could drop them as you did with libtomcrypt in
novacom-client.
Anyway, these two issues are minor enough not be blockers. I trust you to fix
them before importing the package.

So this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.