[Bug 816012] Review Request: python-virtualenvcontext - Switch virtualenvs with a python context manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=816012

--- Comment #8 from Ralph Bean <rbean at redhat.com> 2012-05-08 17:14:40 EDT ---

Spec URL: http://threebean.org/rpm/python-virtualenvcontext.spec
SRPM URL:
http://threebean.org/rpm/python-virtualenvcontext-0.1.4-1.fc17.src.rpm

(In reply to comment #7)
> Issues
> ------
> [!] The LICENSE file is still AGPL, I presume you intended this to 
>     be the GPL 2.0 COPYING?

Yes, another goof on my part.  It should be the correct GPL 2.0 now.  My
apologies for wasting your time.

> [!] Since PKG-INFO is the only file with an overall license claim 
>     (there's nothing in README.rst) include it in %doc

I understand.  It is included in %doc now.

> [!] The Summary: You might consider avoid the term virtualenv in the 
>     summary, it's already in the name; using the name in the summary 
>     is somewhat frowned upon. "Isolated python environments wrapper"?

I still believe this is the correct use.  Use of the virtualenv program is
widespread amongst python developers and the use of the word 'virtualenv' to
denote an environment created by the virtualenv program is common.  I can't
back
this up and will change it to some other language if you insist.

> [!] https://apps.fedoraproject.org/packages/python-virtualenv/ states 
>     the license as "MIT-style permissive license" - that's not GPLv2+.

Unless I'm mistaken, since python-virtualenvcontext *uses* python-virtualenv
and
not the other way around, and since python-virtualenvcontext has the stronger
license, python-virtualenvcontext is not relegated to bearing the same license
as its dependency python-virtualenv.  MIT is GPL-compatible.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.