[Bug 801053] Review Request: fcitx-chewing - Chewing Wrapper for Fcitx

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=801053

--- Comment #2 from Liang Suilong <liangsuilong at gmail.com> 2012-05-12 13:26:50 EDT ---
SPEC:
http://liangsuilong.fedorapeople.org/fcitx/fcitx-chewing-0.1.1-1.fc16.src.rpm
SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-chewing.spec
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4072694


(In reply to comment #1)
> Review:-
> + koji scratch build for f17
> ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4023818
> 
> + rpmlint on rpms gave
> fcitx-chewing.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
> 5)
> fcitx-chewing.src: W: invalid-url Source0:
> http://fcitx.googlecode.com/files/fcitx-chewing-0.1.0.tar.bz2 HTTP Error 404:
> Not Found
> 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> + Source verified with upstream as (sha1sum)
> c8a5ed9db290beae092a198b5b86c31c6d09471a  fcitx-chewing-0.1.0.tar.bz2
> c8a5ed9db290beae092a198b5b86c31c6d09471a 
> ../SOURCES/fcitx-chewing-0.1.0.tar.bz2
> 
> + Package: fcitx-chewing-0.1.0-1.fc17.x86_64
> Provides: fcitx-chewing.so()(64bit)
> Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
> libchewing.so.3()(64bit) rtld(GNU_HASH)
> 
> Suggestions:-
> 1) Fix the rpmlint messages. 
>   a) mixed-use-of-spaces-and-tabs message can be fixed using command
>      sed -i 's|\t| |g' fcitx-chewing.spec

Done

> 
> 2) If package is only for Fedora then no need to add
>   a) %clean section (see
> http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
>   b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
>   c) remove line %defattr(-,root,root,-)
>

The package will be for el6. 

> 3) please don't use commands in macro that is change %{__mkdir} to "mkdir"
> 
Done

> 4) package should add Requires:fcitx, fcitx-data
>

Done

> 5) Use following commands in %build
> %cmake ..
> make VERBOSE=1 %{?_smp_mflags}
>

Done

> 6) You need to use
> http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache as you are
> installing icon files.
> 
Done

> 7) %install should preserve timestamp using 
>    make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
>
Done

> 8) Add COPYING to %doc

Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.