[Bug 822896] Review Request: pari-elldata - PARI/GP Computer Algebra System elliptic curves

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=822896

--- Comment #6 from Ralf Corsepius <rc040203 at freenet.de> ---
(In reply to comment #5)
> (In reply to comment #4)
> > - Shipping the *.asc sig seems pretty meaningless to me.
> 
> I just see it being used as an extra check that the tarball hasn't changed,
> (if we keep the signature in git) given that upstream's releases aren't
> versioned.
I guess you are aware, Fedora's git is automatically adding m5sums to
"sources"?

This would apply if you intend to push the tarball to git's lookaside cache.

However, this would raise the next point, I don't know the answer to: Does
Fedora's git lookaside cache allow unversioned tarballs, rsp. can the lookaside
cache handle this?

> > - I would recommend to use "install -m xxx" instead of "mkdir + cp" in
> > %install.
> > This helps to avoid bad surprizes related to ownership/permissions/umasks.
> 
> It's a bit awkward to do "install" recursively so instead I added a
> %{_fixperms} after the copy to ensure that the built package's permissions
> were sane.
OK with me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/package-review/attachments/20120522/594db44f/attachment.html>