[Fedora-packaging] Proposal to explicitly allow dos2unix

[Paul Howarth]

Alexey Torkhov wrote:
> On Thu, 2009-06-04 at 14:49 -0700, Ray Van Dolson wrote:
>> On Fri, Jun 05, 2009 at 01:44:12AM +0400, Alexey Torkhov wrote:
>>> Hi.
>>>
>>> In guidelines in common errors section
>>> https://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors
>>> there is the following phrase:
>>> ---
>>> This error occurs because of DOS line breaks in a file. Fix it with sed
>>> in the %prep section: %{__sed} -i 's/\r//' src/somefile -- DONT use
>>> dos2unix, that can cause build fail on FC3.
>>> ---
>>>
>>> Because FC3 is not supported for long time, I'm proposing to change it
>>> to:
>>> ---
>>> This error occurs because of DOS line breaks in a file. Fix it with in
>>> the %prep section with sed: <code>%{__sed} -i 's/\r//'
>>> src/somefile</code> or dos2unix.
>>> ---
>>>
>>> Packaging draft is created at
>>> https://fedoraproject.org/wiki/PackagingDrafts/Dos2unix
>>> and added to DraftsTodo page.
>>>
>>> Waiting for comments.
>> Since RHEL4 is based on FC3, would the dos2unix concerns be valid there
>> was well?  Presumably EPEL packages are covered by the packaging
>> guidelines above...
> 
> Supposedly, the bug that results in fail is
> https://bugzilla.redhat.com/show_bug.cgi?id=150277
> 
> Updated the draft with the note that should be added to EPEL-specific
> guidelines.

This issue is fixed in EL-4 too:

https://bugzilla.redhat.com/show_bug.cgi?id=174016

Paul.