[Fedora-packaging] make URL tag mandatory

Tue Aug 13 09:23:30 UTC 2013

Hi Till,

On Tue, Aug 13, 2013 at 2:40 AM, Till Maas <opensource at till.name> wrote:

> On Mon, Aug 12, 2013 at 09:55:25PM +0200, Michael Schwendt wrote:
> > On Mon, 12 Aug 2013 21:35:27 +0200, Till Maas wrote:
>
> > > I noticed that several packages do not contain a URL tag and
> > > http://fedoraproject.org/wiki/Packaging:Guidelines#tags
> > > does not require it. IMHO it would be nicer to have a valid URL tag for
> > > all packages. Therefore I want to propose to make it mandatory.
> > >
> > > What are your opinions?
> >
> > Both the package submitter and the reviewer, who approved the
> > package, should be pointed at:
> >
> >   https://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint
> >
> >   https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
> >   |
> >   | MUST: rpmlint must be run on the source rpm and all binary rpms
> >   | the build produces. The output should be posted in the review.
> >
> > rpmlint warns about a missing URL tag.
>
> I did not check why it happened. The packages from the following SRPM do
> not seem to have the URL tag:
>
> adjtimex-1.29-6.fc19.src.rpm
> arptables_jf-0.0.8-32.fc19.src.rpm
> autofs-5.0.7-14.fc19.src.rpm
> basesystem-10.0-8.fc19.src.rpm
>

  why should this package need a source or URL?

> bitmap-fonts-0.3-20.fc19.src.rpm
>

We have seen issues with font upstream sources. When packages got added
into Fedora they of course used to have correct and valid upstream source
as well as URL. But as time goes these URL seems to vanish.

bootparamd-0.17-38.fc19.src.rpm
> checkpolicy-2.1.12-3.fc19.src.rpm
>

Looks like now source is also not able to be downloaded

> chkconfig-1.3.60-3.fc19.src.rpm
>

This looks like not requested any fedorahosted trac wiki, so there looks no
URL

color-filesystem-1-12.fc19.src.rpm
>

This is a filesystem package so don't think any source or URL will exists
for it

> crypto-utils-2.4.1-39.fc19.src.rpm
> desktop-backgrounds-19.0.0-2.fc19.src.rpm
> duel3-0.1-0.15.20060225.fc19.src.rpm
> dwz-0.10-1.fc19.src.rpm
> finger-0.17-48.fc19.src.rpm
> floppy-support-1.0.0-5.fc19.src.rpm
> fontmatrix-0.9.99-11.r1218.fc19.src.rpm
>

 Does your script checks for actual URL lines in SPEC that got commented?
The reason I have purposefully commented URL line is because upstream was
dead and I want to keep url for my reference as it was committed in initial
release. Do you got any recommendations for fixing this issue?

fonts-KOI8-R-1.0-17.fc19.src.rpm
>

This is very old package in Fedora and whatever I can see about this
package, it never saw any URL and used sources from some website's download
space. That reminds me its merge review is still open as there is no trace
of source.

> freeze-2.5.0-15.fc19.src.rpm
>

This is also old package with source hosted at http://www.ibiblio.org/pub/.
Can then this use URL as  http://www.ibiblio.org ??

generic-release-19-2.src.rpm
>

This looks have its own upstream not hosted anywhere.

gnome-icon-theme-3.8.2-1.fc19.src.rpm
> gnome-icon-theme-extras-3.6.2-2.fc19.src.rpm
> gnome-icon-theme-symbolic-3.8.2.2-1.fc19.src.rpm
> gnome-python2-desktop-2.32.0-14.fc19.src.rpm
> google-croscore-fonts-1.23.0-2.fc19.src.rpm
>

I have still not found any URL for this Google fonts project.

> greylistd-0.8.7-16.fc19.src.rpm
> hesiod-3.2.1-1.fc19.src.rpm
> icon-slicer-0.3-18.fc19.src.rpm
> ilbc-1.1.1-4.fc19.src.rpm
> imlib-1.9.15-23.fc19.src.rpm

iso8859-2-fonts-1.0-28.fc19.src.rpm
>

Another old package. This was also not having any URL but source was hosted
on some website which is already dead now.

japanese-bitmap-fonts-0.20080710-13.fc19.src.rpm
>

This uses various sources with some having URL link commented above source
lines in spec.

jomolhari-fonts-0.003-16.fc19.src.rpm
>

Following is already in SPEC but if both URL is gone, can you suggest what
can be done to enable URL tag for this?

 # Looks like currently following URL is gone now. Maybe temporary issue
#URL:           http://chris.fynn.googlepages.com/jomolhari
# Try following URL for this package
#URL:
https://sites.google.com/site/chrisfynn2/home/fonts/jomolhari

joystick-support-1.0.0-5.fc19.src.rpm
> kcc-2.3-34.src.rpm
> kde-filesystem-4-45.fc19.src.rpm
>

Another filesystem package

> kexec-tools-2.0.3-71.fc19.src.rpm
> kinput2-v3.1-46.fc19.src.rpm
> knm-new-fixed-fonts-1.1-18.fc19.src.rpm
>

Its clearly written in spec
## the following upstream URL is a dead link anymore.
#URL:           http://www.din.or.jp/~storm/fonts/
#Source0:       http://www.din.or.jp/~storm/fonts/knm_new.tar.gz

> konkretcmpi-0.9.0-5.fc19.src.rpm
> libaio-0.3.109-7.fc19.src.rpm
> libcroco-0.6.8-2.fc19.src.rpm
> libdvdnav-4.2.0-4.fc19.src.rpm
> libdvdread-4.2.0-4.fc19.src.rpm
> librsvg2-2.37.0-3.fc19.src.rpm
> mcstrans-0.3.3-6.fc19.src.rpm
> mkbootdisk-1.5.5-10.fc19.src.rpm
> mozilla-filesystem-1.9-9.fc19.src.rpm
>

This looks another filesystem package which should not be having any URL

> mutter-3.8.3-1.fc19.src.rpm
> netdump-server-0.7.16-32.fc19.src.rpm
> newsx-1.6-18.fc19.src.rpm
> perl-srpm-macros-1-7.fc19.src.rpm
> preferences-menus-1-6.fc19.src.rpm
>

This is just single text file source with no upstream needed.

> prelink-0.5.0-1.fc19.src.rpm
> procinfo-18-32.fc19.src.rpm
>

This is another package with source hosted on people page on some website.

> pyorbit-2.24.0-13.fc19.src.rpm
> rarpd-ss981107-40.fc19.src.rpm
> rdma-2.0-8.fc19.src.rpm
> rootfiles-8.1-10.fc19.src.rpm
> rstp-04012009git-10.fc19.src.rpm
> rwho-0.17-51.fc19.src.rpm
> sirius-0.8.0-22.fc19.src.rpm
> telepathy-filesystem-0.0.2-5.fc19.src.rpm
> ttmkfdir-3.0.9-39.fc19.src.rpm
>

 The comment inside spec clearly mentioned its Red Hat maintained package
and source will be available from srpm. Let me see if I can add it to
fedorahosted and then its links in spec

> txt2rss-0.1-10.fc19.src.rpm
> vnc-ltsp-config-4.0-11.fc19.src.rpm
> vte3-0.34.6-1.fc19.src.rpm
> xmms-speex-0.9.1-19.src.rpm
> xorg-x11-drivers-7.7-5.fc19.src.rpm
> scottfree-1.14-7.fc19.src.rpm
> mutter-3.8.4-1.fc19.src.rpm
> gnome-icon-theme-3.8.3-1.fc19.src.rpm
> kexec-tools-2.0.4-7.fc19.src.rpm
> konkretcmpi-0.9.1-1.fc19.src.rpm
> fontmatrix-0.9.99-12.r1218.fc19.src.rpm
>

 Duplicate in this list

> dwz-0.11-1.fc19.src.rpm
> autofs-5.0.7-28.fc19.src.rpm
>
>
We can uncomment the dead URL in spec files but then what to do if someone
reports bug saying URL is not working? Close it as NOTABUG or WONTFIX?

Regards,
Parag.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/packaging/attachments/20130813/374ae674/attachment.html>