[Fedora-packaging] How to handle tests in %check

Miroslav Suchy msuchy at redhat.com
Thu Sep 5 07:21:31 UTC 2013

I would like to ask on your opinion on

Mamoru have in spec in %check section:
   ruby -Ilib:test ./test/run-test.rb || echo "Please investigate this"

I'm saying that it should not be waived this way as it waive all failure.
I'm saying that if there is no failure, it should be just:
   ruby -Ilib:test ./test/run-test.rb
and if there happened some problem which need upstream attention and 
could not be fixed immediatelly, it should be replaced with something like:
   ruby -Ilib:test ./test/run-test.rb | tee $FILE || :
   # test foo is failing, reported as http://foo/issue/1
   cat $FILE | grep "4 tests, 4 assertions, 1 failures, 0 errors, 0 
pendings, 0 omissions, 0 notifications

Mamoru disagree. For me it is blocker.
I would like to ask for your opinions. Which way is correct and should 
it be blocker for review?

Thanks in advance.


More information about the packaging mailing list