[Fedora-packaging] SELinux packing page example results in fedora-review error

[myk]

Hi,



According to

        https://fedoraproject.org/wiki/SELinux_Policy_Modules_Packaging

_Draft

in the "Building the Policy Modules" section the example approach to

build a SELinux policy is:



        %build

        ...

        cd SELinux

        for selinuxvariant in %{selinux_variants}

        do

          make NAME=${selinuxvariant} -f

/usr/share/selinux/devel/Makefile

          mv mymodule.pp mymodule.pp.${selinuxvariant}

          make NAME=${selinuxvariant} -f

/usr/share/selinux/devel/Makefile clean

        done



So for https://bugzilla.redhat.com/show_bug.cgi?id=1209166, in

palo.spec in the %build section, I now looking to use:



        #Use cmake to build

        %cmake ../%{name}-%{version}/

        make %{?_smp_mflags}

        cd -

        #Build the SELinux policy

        cd SELinux

        for selinuxvariant in %{selinux_variants}

        do

          make NAME=${selinuxvariant} -f

/usr/share/selinux/devel/Makefile

          mv %{name}.pp %{name}.pp.${selinuxvariant}

          make NAME=${selinuxvariant} -f

/usr/share/selinux/devel/Makefile clean

        done



But, when running fedora-review, I get the error message:

[!]: Uses parallel make %{?_smp_mflags} macro.



I tried to include %{?_smp_mflags} in the SELinux's Makefile make call,

but this always resulted in an error during rpmbuild.



Since the %{?_smp_mflags} is useful, either 'make' needs to accept -j

against the SELinux Makefile (and the SELinux Packaging page updated),

or fedora-review needs to exclude SELinux Makefile lines when testing

for the %{?_smp_mflags}.



As I don't know what would involved in either approach, would like some

guidance on whether filing a bug report against fedora-review is the

most appropriate next step.



Kind regards,

Michael