[Bug 592672] Review Request: hct - A HDL complexity tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592672

--- Comment #3 from Shakthi Kannan <shakthimaan at gmail.com> 2010-06-15 11:30:26 EDT ---
Upstream was forked into couple of new designs, and hasn't made much progress.
But, this release of the package has over 800 downloads, and is a very useful
tool. So, have chosen this release, and as of now we are upstream.

  <quote>
The big clean-up with %{__rm} -rf `find . -name 'config*' is dangerous.
(Imagine a file name contained a white space). Use "find -name 'config*' -depth
-exec rm -rf -- '{}' \+" or something like that.
  </quote>

Sorry, I didn't understand the difference. In both cases, we still use
'config*' within quotes. Should I change each removal to use "find -name
'config*' -exec rm -rf -- '{}' \+" ?

  <quote>
* Why the hct.pl has '.pl' extension? Is it necessary? Original build system
delivers "hct" wrapper (if it worked). What about just "hct" name or symlink to
hct.pl?
  </quote>

The original wrapper has hard-coded the path as 

  #!/bin/sh
  /Users/smaurer/Downloads/0.7.60/hct.pl $@

Since, we are packaging, we only need the hct.pl file. Since, it is a Perl
script, it has the .pl extension, and I thought it was ok to have it, and thus
haven't changed it. Do you want me to rename the file to simply hct?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.