[perl-MailTools] Nobody else likes macros for commands

Paul Howarth pghmcfc at fedoraproject.org
Wed Jun 1 14:19:04 UTC 2011


commit 5d8856b50476334cd40dc5f3f0a8ae4869483b17
Author: Paul Howarth <paul at city-fan.org>
Date:   Wed Jun 1 15:17:34 2011 +0100

    Nobody else likes macros for commands

 perl-MailTools.spec |   27 ++++++++++++++-------------
 1 files changed, 14 insertions(+), 13 deletions(-)
---
diff --git a/perl-MailTools.spec b/perl-MailTools.spec
index e265585..2b285f1 100644
--- a/perl-MailTools.spec
+++ b/perl-MailTools.spec
@@ -7,9 +7,9 @@ Group:		Development/Libraries
 URL:		http://search.cpan.org/dist/MailTools/
 Source0:	http://search.cpan.org/CPAN/authors/id/M/MA/MARKOV/MailTools-%{version}.tar.gz
 Patch0:		MailTools-2.08-UTF8.patch
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:	noarch
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 BuildRequires:	perl(Date::Format), perl(Date::Parse), perl(ExtUtils::MakeMaker)
 BuildRequires:	perl(Test::More), perl(Test::Pod), perl >= 3:5.8.1
 
@@ -22,33 +22,33 @@ MailTools is a set of Perl modules related to mail applications.
 # Set up example scripts
 cd examples
 for file in *.PL; do
-	%{__perl} $file
+	perl $file
 done
-%{__chmod} -x *_demo
+chmod -x *_demo
 # Remove example-generation scripts, no longer needed
 # It causes warnings from MakeMaker, but we don't care
-%{__rm} *.PL
+rm *.PL
 cd -
 
 # Fix character encodings
 %patch0 -p1
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor
+make %{?_smp_mflags}
 
 %install
-%{__rm} -rf %{buildroot}
-%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
+rm -rf %{buildroot}
+make pure_install PERL_INSTALL_ROOT=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null
 %{_fixperms} %{buildroot}
 
 %check
-%{__make} test
+make test
 
 %clean
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
@@ -106,6 +106,7 @@ cd -
   - Mail::Internet should accept Net::SMTP::SSL as well (CPAN RT#68590)
   - Document that Mail::Mailer::smtps needs Authen::SASL
 - Use patch rather than iconv to convert docs to UTF8 encoding
+- Nobody else likes macros for commands
 
 * Tue Feb 08 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.07-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild



More information about the perl-devel mailing list