[perl-Crypt-DSA] Nobody else likes macros for commands

Paul Howarth pghmcfc at fedoraproject.org
Fri Jun 17 09:06:35 UTC 2011


commit caedf9eb1e1685da8317e1a6255675b42901f7d4
Author: Paul Howarth <paul at city-fan.org>
Date:   Fri Jun 17 09:53:22 2011 +0100

    Nobody else likes macros for commands

 perl-Crypt-DSA.spec |   27 ++++++++++++++-------------
 1 files changed, 14 insertions(+), 13 deletions(-)
---
diff --git a/perl-Crypt-DSA.spec b/perl-Crypt-DSA.spec
index d145403..9ad88e2 100644
--- a/perl-Crypt-DSA.spec
+++ b/perl-Crypt-DSA.spec
@@ -6,8 +6,8 @@ License:	GPL+ or Artistic
 Group:		Development/Libraries
 Url:		http://search.cpan.org/dist/Crypt-DSA/
 Source0:	http://search.cpan.org/CPAN/authors/id/A/AD/ADAMK/Crypt-DSA-%{version}.tar.gz
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 BuildArch:	noarch
 BuildRequires:	perl(Convert::PEM)
 BuildRequires:	perl(Crypt::DES_EDE3)
@@ -29,7 +29,7 @@ Requires:	openssl
 
 # Pull in Math::BigInt::GMP for GMP support for suitably recent versions of Math::BigInt
 # else use Math::GMP
-%if %(%{__perl} -MMath::BigInt -e 'use Math::BigInt 1.87;' 2>/dev/null && echo 1 || echo 0)
+%if %(perl -MMath::BigInt -e 'use Math::BigInt 1.87;' 2>/dev/null && echo 1 || echo 0)
 BuildRequires:	perl(Math::BigInt::GMP)
 Requires:	perl(Math::BigInt::GMP)
 %else
@@ -46,22 +46,22 @@ verification, and key generation.
 %setup -q -n Crypt-DSA-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor
+make %{?_smp_mflags}
 
 %install
-%{__rm} -rf %{buildroot}
-%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
-%{__chmod} -R u+w %{buildroot}/*
+rm -rf %{buildroot}
+make pure_install PERL_INSTALL_ROOT=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null
+chmod -R u+w %{buildroot}
 
 %check
-%{__make} test
-%{__make} test AUTOMATED_TESTING=1 TEST_FILES="xt/*.t"
+make test
+make test AUTOMATED_TESTING=1 TEST_FILES="xt/*.t"
 
 %clean
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
@@ -84,6 +84,7 @@ verification, and key generation.
   - Fixes for 64-bit support
 - Drop upstreamed patches
 - Release tests moved to xt/ directory upstream and now tested separately
+- Nobody else likes macros for commands
 
 * Tue Feb 08 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.16-6
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild



More information about the perl-devel mailing list