[perl-Text-SpellChecker] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Fri Jun 24 09:38:53 UTC 2011


commit 5239ecc63873310f468098926b0931227396c89b
Author: Paul Howarth <paul at city-fan.org>
Date:   Fri Jun 24 10:37:45 2011 +0100

    Spec clean-up
    
    - Nobody else likes macros for commands
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Drop buildroot definition and cleaning
    - Drop redundant defattr

 perl-Text-SpellChecker.spec |   26 ++++++++++++--------------
 1 files changed, 12 insertions(+), 14 deletions(-)
---
diff --git a/perl-Text-SpellChecker.spec b/perl-Text-SpellChecker.spec
index dd3faf0..98d5dbe 100644
--- a/perl-Text-SpellChecker.spec
+++ b/perl-Text-SpellChecker.spec
@@ -7,11 +7,10 @@ Group:		Development/Libraries
 Url:		http://search.cpan.org/dist/Text-SpellChecker/
 Source0:	http://search.cpan.org/CPAN/authors/id/B/BD/BDUGGAN/Text-SpellChecker-%{version}.tar.gz
 Patch0:		Text-SpellChecker-0.09-dictpath.patch
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 BuildArch:	noarch
 BuildRequires:	perl(ExtUtils::MakeMaker), perl(Text::Hunspell), perl(Test::More)
 BuildRequires:	hunspell-en
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:	perl(Text::Hunspell)
 
 %description
@@ -28,26 +27,21 @@ and highlighting the current misspelled word within the text.
 %patch0 -p1
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor
+make %{?_smp_mflags}
 
 %install
-%{__rm} -rf %{buildroot}
-%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
-%{__chmod} -R u+w %{buildroot}
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null
+chmod -R u+w %{buildroot}
 
 %check
 # Note that Text::Aspell is retired from Fedora after Fedora 15
 # so we don't try the Aspell tests
-%{__make} test TEST_VERBOSE=1
-
-%clean
-%{__rm} -rf %{buildroot}
+make test TEST_VERBOSE=1
 
 %files
-%defattr(-,root,root,-)
 %doc Changes README
 %{perl_vendorlib}/Text/
 %{_mandir}/man3/Text::SpellChecker.3pm*
@@ -59,6 +53,10 @@ and highlighting the current misspelled word within the text.
   - Compile time check for at least one speller
 - Update dictionary path patch
 - Drop test suite patch, no longer needed
+- Nobody else likes macros for commands
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Drop buildroot definition and cleaning
+- Drop redundant defattr
 
 * Mon Jun 20 2011 Marcela Mašláňová <mmaslano at redhat.com> - 0.08-3
 - Perl mass rebuild



More information about the perl-devel mailing list