[perl-Test-Log-Dispatch] Reflect feedback from package review. Spec file overhaul.

corsepiu corsepiu at fedoraproject.org
Mon Mar 14 04:47:50 UTC 2011


commit 636e04b12504707a42578b9658c5062236a0bcc1
Author: Ralf Corsépius <corsepiu at fedoraproject.org>
Date:   Mon Mar 14 05:47:36 2011 +0100

    Reflect feedback from package review.
    Spec file overhaul.

 perl-Test-Log-Dispatch.spec |   14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/perl-Test-Log-Dispatch.spec b/perl-Test-Log-Dispatch.spec
index 048884f..c5f9dfd 100644
--- a/perl-Test-Log-Dispatch.spec
+++ b/perl-Test-Log-Dispatch.spec
@@ -1,12 +1,11 @@
 Name:           perl-Test-Log-Dispatch
 Version:        0.03
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Test what you are logging
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Test-Log-Dispatch/
 Source0:        http://www.cpan.org/authors/id/J/JS/JSWARTZ/Test-Log-Dispatch-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
 
 BuildRequires:  perl(ExtUtils::MakeMaker)
@@ -16,7 +15,7 @@ BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Tester)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
-%if 0%fedora < 15
+%if 0%{?fedora} < 15
 # Fedora < 15's rpm misses this
 Requires:	perl(Log::Dispatch)
 %endif
@@ -34,8 +33,6 @@ what has been logged.
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
 
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
@@ -46,9 +43,6 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 %check
 make test
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
 %defattr(-,root,root,-)
 %doc Changes README
@@ -56,5 +50,9 @@ rm -rf $RPM_BUILD_ROOT
 %{_mandir}/man3/*
 
 %changelog
+* Mon Mar 14 2011 Ralf Corsépius <corsepiu at fedoraproject.org> 0.03-2
+- Reflect feedback from package review.
+- Spec file overhaul.
+
 * Mon Feb 07 2011 Ralf Corsépius <corsepiu at fedoraproject.org> 0.03-1
 - Specfile autogenerated by cpanspec 1.78.



More information about the perl-devel mailing list