[Bug 663931] regression from 0.710.08 soap:Client, Application failed during request deserialization

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663931

Mike B. <michiel.beijen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(michiel.beijen at gm |
                   |ail.com)                    |

--- Comment #3 from Mike B. <michiel.beijen at gmail.com> 2011-05-12 06:27:04 EDT ---
You mean the part where Martin says:

> it's not just three characters: The change from read() to sysread() 
> was introduced due to another bug report (have to look up the number),
>  which reported read() to be broken under windows (never returns 0 
> to indicate the request was read completely).

I guess we don't need to bother about Windows support in the Fedora package :D
but apart from that, also citing the bug report:

> The reason it's a problem is that under mod_perl, STDIN is not a 
> real filehandle - it's mapped to the request object. CORE:: file 
> operations (read/print/etc.) work fine, but sysread specifically tries 
> to treat as a file handle.

This means that using sysread() fixed the issue with SOAP::Lite on Windows, but
when using mod_perl (on linux OR Windows) as stated STDIN is not a real file
handle, and thus this change causes issues for those scenarios.

The patch checks if SOAP::Lite is running in a mod_perl environment, and if
this is the case, uses read() instead of sysread(). So yes, the fix is fine.
Apart from that, it's running on a lot of OTRS systems in production at the
moment, because this issue breaks the RPC/XML interface of OTRS (and Bugzilla,
as well) when deployed under mod_perl.

--
Mike

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.