[perl-IPTables-ChainMgr] Avoid deprecated use of qw()

Miloslav Trmac mitr at fedoraproject.org
Wed Jan 11 11:22:36 UTC 2012


commit 49ce31e482026fa9cf1defa5d42fa33e99ad72a3
Author: Miloslav Trmač <mitr at redhat.com>
Date:   Tue Jan 10 22:52:18 2012 +0100

    Avoid deprecated use of qw()

 IPTables-ChainMgr-0.9-qw.patch |   67 ++++++++++++++++++++++++++++++++++++++++
 perl-IPTables-ChainMgr.spec    |    8 ++++-
 2 files changed, 74 insertions(+), 1 deletions(-)
---
diff --git a/IPTables-ChainMgr-0.9-qw.patch b/IPTables-ChainMgr-0.9-qw.patch
new file mode 100644
index 0000000..accd377
--- /dev/null
+++ b/IPTables-ChainMgr-0.9-qw.patch
@@ -0,0 +1,67 @@
+Avoid "Use of qw(...) as parentheses is deprecated" warnings
+
+See http://search.cpan.org/~jesse/perl-5.14.0/pod/perl5135delta.pod#Use_of_qw%28...%29_as_parentheses
+diff -ur IPTables-ChainMgr/lib/IPTables/ChainMgr.pm IPTables-ChainMgr-0.9/lib/IPTables/ChainMgr.pm
+--- IPTables-ChainMgr/lib/IPTables/ChainMgr.pm	2009-02-12 05:20:16.000000000 +0100
++++ IPTables-ChainMgr-0.9/lib/IPTables/ChainMgr.pm	2012-01-06 15:20:15.055429198 +0100
+@@ -155,7 +155,7 @@
+         if ($extended_href) {
+             $msg = "Table: $table, chain: $chain, $normalized_src -> " .
+                 "$normalized_dst ";
+-            for my $key qw(protocol s_port d_port mac_source) {
++            for my $key (qw(protocol s_port d_port mac_source)) {
+                 $msg .= "$key $extended_href->{$key} "
+                     if defined $extended_href->{$key};
+             }
+@@ -188,7 +188,7 @@
+ 
+         $msg = "Table: $table, chain: $chain, added $normalized_src " .
+             "-> $normalized_dst ";
+-        for my $key qw(protocol s_port d_port mac_source) {
++        for my $key (qw(protocol s_port d_port mac_source)) {
+             $msg .= "$key $extended_href->{$key} "
+                 if defined $extended_href->{$key};
+         }
+@@ -244,7 +244,7 @@
+         if ($extended_href) {
+             $msg = "Table: $table, chain: $chain, $normalized_src -> " .
+                 "$normalized_dst ";
+-            for my $key qw(protocol s_port d_port mac_source) {
++            for my $key (qw(protocol s_port d_port mac_source)) {
+                 $msg .= "$key $extended_href->{$key} "
+                     if defined $extended_href->{$key};
+             }
+@@ -287,7 +287,7 @@
+ 
+         $msg = "Table: $table, chain: $chain, added $normalized_src " .
+             "-> $normalized_dst ";
+-        for my $key qw(protocol s_port d_port mac_source) {
++        for my $key (qw(protocol s_port d_port mac_source)) {
+             $msg .= "$key $extended_href->{$key} "
+                 if defined $extended_href->{$key};
+         }
+@@ -344,7 +344,7 @@
+ 
+     my $extended_msg = '';
+     if ($extended_href) {
+-        for my $key qw(protocol s_port d_port mac_source) {
++        for my $key (qw(protocol s_port d_port mac_source)) {
+             $extended_msg .= "$key: $extended_href->{$key} "
+                 if defined $extended_href->{$key};
+         }
+@@ -403,13 +403,13 @@
+                 and $rule_href->{'dst'} eq $dst) {
+             if ($extended_href) {
+                 my $found = 1;
+-                for my $key qw(
++                for my $key (qw(
+                     protocol
+                     s_port
+                     d_port
+                     to_ip
+                     to_port
+-                ) {
++                )) {
+                     if (defined $extended_href->{$key}) {
+                         unless ($extended_href->{$key}
+                                 eq $rule_href->{$key}) {
diff --git a/perl-IPTables-ChainMgr.spec b/perl-IPTables-ChainMgr.spec
index bc29721..821c434 100644
--- a/perl-IPTables-ChainMgr.spec
+++ b/perl-IPTables-ChainMgr.spec
@@ -1,12 +1,13 @@
 Name:           perl-IPTables-ChainMgr
 Version:        0.9
-Release:        8%{?dist}
+Release:        9%{?dist}
 Summary:        Perl extension for manipulating iptables policies
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://www.cipherdyne.org/modules/
 Source0:        http://www.cipherdyne.org/modules/IPTables-ChainMgr-%{version}.tar.bz2
 Source1:        http://www.cipherdyne.org/modules/IPTables-ChainMgr-%{version}.tar.bz2.asc
+Patch0:         IPTables-ChainMgr-0.9-qw.patch
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(IPTables::Parse), perl(Net::IPv4Addr)
@@ -24,6 +25,7 @@ binary instead of having to compile against a library.
 
 %prep
 %setup -q -n IPTables-ChainMgr-%{version}
+%patch0 -p1
 
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
@@ -50,6 +52,10 @@ rm -rf $RPM_BUILD_ROOT
 %{_mandir}/man3/*
 
 %changelog
+* Tue Jan 10 2012 Miloslav Trmač <mitr at redhat.com> - 0.9-9
+- Avoid deprecated use of qw()
+  Resolves: #771781
+
 * Tue Jun 21 2011 Marcela Mašláňová <mmaslano at redhat.com> - 0.9-8
 - Perl mass rebuild
 



More information about the perl-devel mailing list