[perl-Digest-MD2] Spec clean-up

[Paul Howarth]

commit 1bc382317f8a8aa5cdf09271f0e0810257a6ae93
Author: Paul Howarth <paul at city-fan.org>
Date:   Wed Jan 11 13:09:45 2012 +0000

    Spec clean-up
    
    - Nobody else likes macros for commands
    - Use a patch rather than scripted iconv to fix character encoding
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Use %{_fixperms} macro rather than our own chmod incantation

 Digest-MD2-2.03-utf8.patch |   11 +++++++++
 perl-Digest-MD2.spec       |   49 +++++++++++++++++++++++++------------------
 2 files changed, 39 insertions(+), 21 deletions(-)
---
diff --git a/Digest-MD2-2.03-utf8.patch b/Digest-MD2-2.03-utf8.patch
new file mode 100644
index 0000000..b2c0fb3
--- /dev/null
+++ b/Digest-MD2-2.03-utf8.patch
@@ -0,0 +1,11 @@
+--- Digest-MD2/Changes
++++ Digest-MD2/Changes
+@@ -56,7 +56,7 @@
+    
+    The fallback code introduced in 2.10 did only work for
+    perl-5.6.0.  It should now for for perl5.004 and 5.005
+-   as well.  Patch by Ville Skyttä <ville at office.popsystems.com>.
++   as well.  Patch by Ville Skyttä <ville at office.popsystems.com>.
+ 
+ 
+ 
diff --git a/perl-Digest-MD2.spec b/perl-Digest-MD2.spec
index 0caa020..314e621 100644
--- a/perl-Digest-MD2.spec
+++ b/perl-Digest-MD2.spec
@@ -1,14 +1,15 @@
 Summary:	Perl interface to the MD2 Algorithm
 Name:		perl-Digest-MD2
 Version:	2.03
-Release:	17%{?dist}
+Release:	18%{?dist}
 License:	GPL+ or Artistic
 Group:		Development/Libraries
 Url:		http://search.cpan.org/dist/Digest-MD2/
 Source0:	http://search.cpan.org/CPAN/authors/id/G/GA/GAAS/Digest-MD2-%{version}.tar.gz
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Patch0:		Digest-MD2-2.03-utf8.patch
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildRequires:	perl(ExtUtils::MakeMaker)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 # Don't "provide" private Perl libs
 %{?perl_default_filter}
@@ -26,26 +27,25 @@ Digest::MD5.
 %setup -q -n Digest-MD2-%{version}
 
 # Convert docs to UTF-8 encoding
-/usr/bin/iconv -f iso-8859-1 -t utf-8 < Changes > Changes.utf8
-%{__mv} -f Changes.utf8 Changes
+%patch0 -p1
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
-%{__make} %{?_smp_mflags}
-
-%check
-%{__make} test
+perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
+make %{?_smp_mflags}
 
 %install
-%{__rm} -rf %{buildroot}
-%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -type f -name '*.bs' -a -size 0 -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
-%{__chmod} -R u+w %{buildroot}
+rm -rf %{buildroot}
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
+find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null
+%{_fixperms} %{buildroot}
+
+%check
+make test
 
 %clean
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
@@ -55,14 +55,21 @@ Digest::MD5.
 %{_mandir}/man3/Digest::MD2.3pm*
 
 %changelog
-* Fri Jun 17 2011 Marcela Mašláňová <mmaslano at redhat.com> - 2.03-17
+* Wed Jan 11 2012 Paul Howarth <paul at city-fan.org> 2.03-18
+- Spec clean-up:
+  - Nobody else likes macros for commands
+  - Use a patch rather than scripted iconv to fix character encoding
+  - Use DESTDIR rather than PERL_INSTALL_ROOT
+  - Use %%{_fixperms} macro rather than our own chmod incantation
+
+* Fri Jun 17 2011 Marcela Mašláňová <mmaslano at redhat.com> 2.03-17
 - Perl mass rebuild
 
-* Tue Feb 08 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.03-16
+* Tue Feb  8 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> 2.03-16
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
-* Thu Dec 16 2010 Marcela Maslanova <mmaslano at redhat.com> - 2.03-15
-- 661697 rebuild for fixing problems with vendorach/lib
+* Thu Dec 16 2010 Marcela Maslanova <mmaslano at redhat.com> 2.03-15
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Tue May 11 2010 Paul Howarth <paul at city-fan.org> 2.03-14
 - Use %%{?perl_default_filter} for provides filter