[perl-Digest-MD4] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Wed Jan 11 14:17:53 UTC 2012


commit d816bd5b0c48ffe235e0682e3836ca545f9fcd6a
Author: Paul Howarth <paul at city-fan.org>
Date:   Wed Jan 11 14:17:15 2012 +0000

    Spec clean-up
    
    - Nobody else likes macros for commands
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Use %{_fixperms} macro rather than our own chmod incantation

 perl-Digest-MD4.spec |   44 +++++++++++++++++++++++++-------------------
 1 files changed, 25 insertions(+), 19 deletions(-)
---
diff --git a/perl-Digest-MD4.spec b/perl-Digest-MD4.spec
index 482e592..a3e78b6 100644
--- a/perl-Digest-MD4.spec
+++ b/perl-Digest-MD4.spec
@@ -1,14 +1,14 @@
 Name:		perl-Digest-MD4
 Version:	1.5
-Release:	16%{?dist}
+Release:	17%{?dist}
 Summary:	Perl interface to the MD4 Algorithm
 Group:		Development/Libraries
 License:	GPL+ or Artistic
 URL:		http://search.cpan.org/dist/Digest-MD4/
 Source0:	http://search.cpan.org/CPAN/authors/id/M/MI/MIKEM/DigestMD4/Digest-MD4-%{version}.tar.gz
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildRequires:	perl(ExtUtils::MakeMaker), db4-devel, gdbm-devel
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 # Don't "provide" private Perl libs
 %{?perl_default_filter}
@@ -23,22 +23,22 @@ message of arbitrary length and produces as output a 128-bit "fingerprint" or
 %setup -q -n Digest-MD4-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
+make %{?_smp_mflags}
 
 %install
-%{__rm} -rf %{buildroot}
-%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -type f -name '*.bs' -empty -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
-%{__chmod} -R u+w %{buildroot}/*
+rm -rf %{buildroot}
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+find %{buildroot} -type f -name '*.bs' -empty -exec rm -f {} ';'
+find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null
+%{_fixperms} %{buildroot}
 
 %check
-%{__make} test
+make test
 
 %clean
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
@@ -48,20 +48,26 @@ message of arbitrary length and produces as output a 128-bit "fingerprint" or
 %{_mandir}/man3/Digest::MD4.3pm*
 
 %changelog
+* Wed Jan 11 2012 Paul Howarth - 1.5-17
+- spec clean-up:
+  - nobody else likes macros for commands
+  - use DESTDIR rather than PERL_INSTALL_ROOT
+  - use %%{_fixperms} macro rather than our own chmod incantation
+
 * Thu Jun 16 2011 Marcela Mašláňová <mmaslano at redhat.com> - 1.5-16
-- Perl mass rebuild
+- perl mass rebuild
 
 * Tue Feb 08 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.5-15
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
+- rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Thu Dec 16 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.5-14
-- 661697 rebuild for fixing problems with vendorach/lib
+- rebuild to fix problems with vendorarch/lib (#661697)
 
-* Sat May 01 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.5-13
-- Mass rebuild with perl-5.12.0
+* Sat May  1 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.5-13
+- mass rebuild with perl-5.12.0
 
 * Fri Apr 30 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.5-12
-- Mass rebuild with perl-5.12.0
+- mass rebuild with perl-5.12.0
 
 * Mon Dec  7 2009 Stepan Kasal <skasal at redhat.com> - 1.5-11
 - rebuild against perl 5.10.1



More information about the perl-devel mailing list