[perl-IPC-System-Simple] Spec clean-up
Paul Howarth
pghmcfc at fedoraproject.org
Thu Jan 12 10:45:09 UTC 2012
commit ef8279a6405cff304fcfc7e89ee7de3b7c1fbc11
Author: Paul Howarth <paul at city-fan.org>
Date: Thu Jan 12 10:44:37 2012 +0000
Spec clean-up
- Run author tests too for completeness
- Add buildreqs needed for author tests
- Add buildreqs for core perl modules, which may be dual-lived
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Make %files list more explicit
perl-IPC-System-Simple.spec | 110 ++++++++++++++++++++++---------------------
1 files changed, 57 insertions(+), 53 deletions(-)
---
diff --git a/perl-IPC-System-Simple.spec b/perl-IPC-System-Simple.spec
index f65f213..8239091 100644
--- a/perl-IPC-System-Simple.spec
+++ b/perl-IPC-System-Simple.spec
@@ -1,34 +1,33 @@
-Name: perl-IPC-System-Simple
-Version: 1.21
-Release: 2%{?dist}
-# lib/IPC/System/Simple.pm -> GPL+ or Artistic
-License: GPL+ or Artistic
-Group: Development/Libraries
-Summary: Run commands simply, with detailed diagnostics
-Source: http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-%{version}.tar.gz
-Url: http://search.cpan.org/dist/IPC-System-Simple
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-BuildArch: noarch
-
-BuildRequires: perl(ExtUtils::MakeMaker) >= 6.42
-BuildRequires: perl(Config)
-BuildRequires: perl(File::Basename)
-BuildRequires: perl(File::Spec)
-BuildRequires: perl(List::Util)
-BuildRequires: perl(Scalar::Util)
-# testing
-BuildRequires: perl(BSD::Resource)
-BuildRequires: perl(Test)
-BuildRequires: perl(Test::More)
-BuildRequires: perl(Test::NoWarnings)
-# These are explicitly marked as AUTHOR_TESTS, and we skip those.
-#BuildRequires: perl(Test::Pod)
-#BuildRequires: perl(Test::Pod::Coverage)
-
-
+Name: perl-IPC-System-Simple
+Version: 1.21
+Release: 3%{?dist}
+License: GPL+ or Artistic
+Group: Development/Libraries
+Summary: Run commands simply, with detailed diagnostics
+Url: http://search.cpan.org/dist/IPC-System-Simple
+Source: http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-%{version}.tar.gz
+BuildArch: noarch
+BuildRequires: perl(BSD::Resource)
+BuildRequires: perl(Carp)
+BuildRequires: perl(Config)
+BuildRequires: perl(Exporter)
+BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(File::Basename)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(List::Util)
+BuildRequires: perl(POSIX)
+BuildRequires: perl(Scalar::Util)
+BuildRequires: perl(Test)
+BuildRequires: perl(Test::Kwalitee)
+BuildRequires: perl(Test::More)
+BuildRequires: perl(Test::NoWarnings)
+BuildRequires: perl(Test::Perl::Critic)
+BuildRequires: perl(Test::Pod)
+BuildRequires: perl(Test::Pod::Coverage)
+Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description
-Calling Perl's in-built 'system()' function is easy, determining if it
+Calling Perl's in-built 'system()' function is easy; determining if it
was successful is _hard_. Let's face it, '$?' isn't the nicest variable
in the world to play with, and even if you _do_ check it, producing a
well-formatted error string takes a lot of work. 'IPC::System::Simple'
@@ -37,62 +36,67 @@ want to be really lazy, you can just write:
use IPC::System::Simple qw(system);
-and all of your "system" commands will either succeeed (run to completion and
+and all of your "system" commands will either succeed (run to completion and
return a zero exit value), or die with rich diagnostic messages.
-
%prep
%setup -q -n IPC-System-Simple-%{version}
-find . -type f -exec chmod -x {} \;
+# Avoid doc-file dependencies
+chmod -c -x examples/*.pl
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
+make pure_install DESTDIR=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} %{buildroot}/*
+find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
+%{_fixperms} %{buildroot}
%check
-make test
+make test TEST_AUTHOR=1
%files
-%defattr(-,root,root,-)
-%doc Changes LICENSE README examples/
-%{perl_vendorlib}/*
-%{_mandir}/man3/*.3*
+%doc Changes LICENSE README examples/
+%{perl_vendorlib}/IPC/
+%{_mandir}/man3/IPC::System::Simple.3pm*
%changelog
+* Thu Jan 12 2012 Paul Howarth <paul at city-fan.org> - 1.21-3
+- Run author tests too for completeness
+- Add buildreqs needed for author tests
+- Add buildreqs for core perl modules, which may be dual-lived
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Make %%files list more explicit
+
* Wed Jul 20 2011 Petr Sabata <contyk at redhat.com> - 1.21-2
- Perl mass rebuild
-* Fri Mar 18 2011 Iain Arnell <iarnell at gmail.com> 1.21-1
-- update to latest upstream version
-- clean up spec for modern rpmbuild
+* Fri Mar 18 2011 Iain Arnell <iarnell at gmail.com> - 1.21-1
+- Update to latest upstream version
+- Clean up spec for modern rpmbuild
* Tue Feb 08 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.18-6
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Mon Dec 20 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.18-5
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
* Sun May 02 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.18-4
- Mass rebuild with perl-5.12.0
-* Mon Dec 7 2009 Stepan Kasal <skasal at redhat.com> - 1.18-3
-- rebuild against perl 5.10.1
+* Mon Dec 07 2009 Stepan Kasal <skasal at redhat.com> - 1.18-3
+- Rebuild against perl 5.10.1
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.18-2
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
-* Thu Mar 05 2009 Chris Weyl <cweyl at alumni.drew.edu> 1.18-1
-- submission
+* Thu Mar 05 2009 Chris Weyl <cweyl at alumni.drew.edu> - 1.18-1
+- Submission
-* Thu Mar 05 2009 Chris Weyl <cweyl at alumni.drew.edu> 1.18-0
-- initial RPM packaging
-- generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.8)
+* Thu Mar 05 2009 Chris Weyl <cweyl at alumni.drew.edu> - 1.18-0
+- Initial RPM packaging
+- Generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.8)
More information about the perl-devel
mailing list