[perl-Net-SSH-Perl] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Thu Jan 12 14:55:53 UTC 2012


commit 80b90feffec5772a82b066e1ee6b6e21947624bd
Author: Paul Howarth <paul at city-fan.org>
Date:   Thu Jan 12 14:55:20 2012 +0000

    Spec clean-up
    
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Use %{_fixperms} macro rather than our own chmod incantation
    - Add buildreqs not mentioned in module metadata

 perl-Net-SSH-Perl.spec |   25 +++++++++++++++++++++----
 1 files changed, 21 insertions(+), 4 deletions(-)
---
diff --git a/perl-Net-SSH-Perl.spec b/perl-Net-SSH-Perl.spec
index 5783d87..4ee45d7 100644
--- a/perl-Net-SSH-Perl.spec
+++ b/perl-Net-SSH-Perl.spec
@@ -4,7 +4,7 @@
 Summary:	SSH (Secure Shell) client
 Name:		perl-Net-SSH-Perl
 Version:	1.34
-Release:	13%{?dist}
+Release:	14%{?dist}
 License:	GPL+ or Artistic
 Group:		Development/Libraries
 Url:		http://search.cpan.org/dist/Net-SSH-Perl/
@@ -14,9 +14,11 @@ Source2:	161C06B1.asc
 Patch0:		Net-SSH-Perl-1.34-stopwords.patch
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:	noarch
-BuildRequires:	perl(String::CRC32)		>= 1.2
+BuildRequires:	perl(Carp)
+BuildRequires:	perl(Compress::Zlib)
 BuildRequires:	perl(Convert::PEM)		>= 0.05
 BuildRequires:	perl(Crypt::Blowfish)
+BuildRequires:	perl(Crypt::DES)
 BuildRequires:	perl(Crypt::DH)			>= 0.01
 BuildRequires:	perl(Crypt::DSA)		>= 0.11
 BuildRequires:	perl(Crypt::RSA)
@@ -26,10 +28,20 @@ BuildRequires:	perl(Digest::HMAC_SHA1)
 BuildRequires:	perl(Digest::MD5)
 BuildRequires:	perl(Digest::SHA1)		>= 2.10
 BuildRequires:	perl(ExtUtils::MakeMaker)
+BuildRequires:	perl(Fcntl)
+BuildRequires:	perl(IO::Select)
+BuildRequires:	perl(IO::Socket)
 BuildRequires:	perl(Math::GMP)			>= 1.04
 BuildRequires:	perl(Math::Pari)		>= 2.001804
 BuildRequires:	perl(MIME::Base64)
+BuildRequires:	perl(POSIX)
+BuildRequires:	perl(Scalar::Util)
+BuildRequires:	perl(Socket)
+BuildRequires:	perl(String::CRC32)		>= 1.2
+BuildRequires:	perl(Symbol)
+BuildRequires:	perl(Sys::Hostname)
 BuildRequires:	perl(Test::More)
+BuildRequires:	perl(Tie::Handle)
 # Additional test coverage
 BuildRequires:	perl(Module::Signature)
 BuildRequires:	perl(Test::Pod)			>= 0.95
@@ -96,10 +108,10 @@ cd -
 
 %install
 rm -rf %{buildroot}
-make -C Net-SSH-Perl-%{version} pure_install PERL_INSTALL_ROOT=%{buildroot}
+make -C Net-SSH-Perl-%{version} pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
 find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null
-chmod -R u+w %{buildroot}
+%{_fixperms} %{buildroot}
 
 %check
 # Critic and POD tests currently fail
@@ -128,6 +140,11 @@ rm -rf %{buildroot}
 %{_mandir}/man3/Net::SSH::Perl*.3pm*
 
 %changelog
+* Thu Jan 12 2012 Paul Howarth <paul at city-fan.org> 1.34-14
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Use %%{_fixperms} macro rather than our own chmod incantation
+- Add buildreqs not mentioned in module metadata
+
 * Wed Jul 20 2011 Paul Howarth <paul at city-fan.org> 1.34-13
 - Perl mass rebuild
 - Work around MYMETA.yml causing signature test to fail



More information about the perl-devel mailing list