[perl-Archive-Any] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Tue Jan 17 11:56:44 UTC 2012


commit 437a544062d189d56e4c733f7dcf7edbac98e6c5
Author: Paul Howarth <paul at city-fan.org>
Date:   Tue Jan 17 11:56:09 2012 +0000

    Spec clean-up
    
    - Drop redundant buildreq perl(Test::Perl::Critic)
    - Make %files list more explicit
    - Group buildreqs by build/module/test
    - Don't use macros for commands
    - Use tabs

 .gitignore            |    2 +-
 perl-Archive-Any.spec |   85 +++++++++++++++++++++++++-----------------------
 2 files changed, 45 insertions(+), 42 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 0041044..cb778b1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Archive-Any-0.0932.tar.gz
+/Archive-Any-[0-9.]*.tar.gz
diff --git a/perl-Archive-Any.spec b/perl-Archive-Any.spec
index e277c7b..dd4425a 100644
--- a/perl-Archive-Any.spec
+++ b/perl-Archive-Any.spec
@@ -1,36 +1,30 @@
-Name:           perl-Archive-Any
-Version:        0.0932
-Release:        8%{?dist}
-Summary:        Single interface to deal with file archives
-License:        GPL+ or Artistic
-Group:          Development/Libraries
-URL:            http://search.cpan.org/dist/Archive-Any/
-Source0:        http://search.cpan.org/CPAN/authors/id/C/CM/CMOORE/Archive-Any-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildArch:      noarch
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-
-# core
-BuildRequires:  perl(Cwd)
-BuildRequires:  perl(File::Spec::Functions)
-BuildRequires:  perl(Test::More) >= 0.4
-# cpan
-BuildRequires:  perl(Archive::Tar) >= 0.22
-BuildRequires:  perl(Archive::Zip) >= 1.07
-BuildRequires:  perl(File::MMagic) >= 1.27
-BuildRequires:  perl(MIME::Types) >= 1.16
-BuildRequires:  perl(Module::Build)
-BuildRequires:  perl(Module::Find) >= 0.05
-# testing
-BuildRequires:  perl(Test::Pod), perl(Test::Pod::Coverage)
-BuildRequires:  perl(Test::Perl::Critic)
-BuildRequires:  perl(Test::Warn)
-
-#Requires:       perl(Archive::Tar) >= 0.22
-#Requires:       perl(Archive::Zip) >= 1.07
-#Requires:       perl(File::MMagic) >= 1.27
-#Requires:       perl(MIME::Types) >= 1.16
-#Requires:       perl(Module::Find) >= 0.05
+Name:		perl-Archive-Any
+Version:	0.0932
+Release:	9%{?dist}
+Summary:	Single interface to deal with file archives
+License:	GPL+ or Artistic
+Group:		Development/Libraries
+URL:		http://search.cpan.org/dist/Archive-Any/
+Source0:	http://search.cpan.org/CPAN/authors/id/C/CM/CMOORE/Archive-Any-%{version}.tar.gz
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch:	noarch
+# Build
+BuildRequires:	perl(Module::Build)
+# Module
+BuildRequires:	perl(Archive::Tar) >= 0.22
+BuildRequires:	perl(Archive::Zip) >= 1.07
+BuildRequires:	perl(Cwd)
+BuildRequires:	perl(File::MMagic) >= 1.27
+BuildRequires:	perl(File::Spec::Functions)
+BuildRequires:	perl(MIME::Types) >= 1.16
+BuildRequires:	perl(Module::Find) >= 0.05
+# Test suite
+BuildRequires:	perl(Test::More) >= 0.4
+BuildRequires:	perl(Test::Pod)
+BuildRequires:	perl(Test::Pod::Coverage)
+BuildRequires:	perl(Test::Warn)
+# Runtime
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This module is a single interface for manipulating different archive
@@ -40,16 +34,14 @@ formats. Tarballs, zip files, etc.
 %setup -q -n Archive-Any-%{version}
 
 %build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
 ./Build
 
 %install
 rm -rf %{buildroot}
-
 ./Build install destdir=%{buildroot} create_packlist=0
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} %{buildroot}/*
+find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
+%{_fixperms} %{buildroot}
 
 %check
 ./Build test
@@ -60,10 +52,21 @@ rm -rf %{buildroot}
 %files
 %defattr(-,root,root,-)
 %doc Changes README t/
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/Archive/
+%{_mandir}/man3/Archive::Any.3pm*
+%{_mandir}/man3/Archive::Any::Plugin.3pm*
+%{_mandir}/man3/Archive::Any::Plugin::Tar.3pm*
+%{_mandir}/man3/Archive::Any::Plugin::Zip.3pm*
 
 %changelog
+* Tue Jan 17 2012 Paul Howarth <paul at city-fan.org> - 0.0932-9
+- Spec clean-up:
+  - Drop redundant buildreq perl(Test::Perl::Critic)
+  - Make %%files list more explicit
+  - Group buildreqs by build/module/test
+  - Don't use macros for commands
+  - Use tabs
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.0932-8
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -74,7 +77,7 @@ rm -rf %{buildroot}
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Wed Dec 15 2010 Marcela Maslanova <mmaslano at redhat.com> - 0.0932-5
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Thu Apr 29 2010 Marcela Maslanova <mmaslano at redhat.com> - 0.0932-4
 - Mass rebuild with perl-5.12.0



More information about the perl-devel mailing list