[perl-Class-C3-XS] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Wed Jan 18 14:00:53 UTC 2012


commit 3dfa03da245e92de37889181ae8f53ba2058cf50
Author: Paul Howarth <paul at city-fan.org>
Date:   Wed Jan 18 14:00:19 2012 +0000

    Spec clean-up
    
    - BR: perl(Sub::Name) for testing
    - Make %files list more explicit
    - Filter unwanted requires and provides
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Use tabs

 .gitignore            |    2 +-
 perl-Class-C3-XS.spec |  111 +++++++++++++++++++++++++++----------------------
 2 files changed, 62 insertions(+), 51 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 5ecface..0aab967 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Class-C3-XS-0.13.tar.gz
+/Class-C3-XS-[0-9.]*.tar.gz
diff --git a/perl-Class-C3-XS.spec b/perl-Class-C3-XS.spec
index 5a208d4..67a517c 100644
--- a/perl-Class-C3-XS.spec
+++ b/perl-Class-C3-XS.spec
@@ -1,21 +1,21 @@
-Name:           perl-Class-C3-XS
-Version:        0.13
-Release:        7%{?dist}
-Summary:        XS speedups for Class::C3
-License:        GPL+ or Artistic
-Group:          Development/Libraries
-URL:            http://search.cpan.org/dist/Class-C3-XS/
-Source0:        http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Class-C3-XS-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-
-# core
-BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.42
-BuildRequires:  perl(Test::More) >= 0.47
-# test
-BuildRequires:  perl(Test::Pod)
-
-# don't "provide" private Perl libs
+Name:		perl-Class-C3-XS
+Version:	0.13
+Release:	8%{?dist}
+Summary:	XS speedups for Class::C3
+License:	GPL+ or Artistic
+Group:		Development/Libraries
+URL:		http://search.cpan.org/dist/Class-C3-XS/
+Source0:	http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Class-C3-XS-%{version}.tar.gz
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildRequires:	perl(ExtUtils::MakeMaker)
+BuildRequires:	perl(Sub::Name)
+BuildRequires:	perl(Test::More) >= 0.47
+BuildRequires:	perl(Test::Pod)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+
+# Filter bogus requires/provides
+%{?filter_from_requires: %filter_from_requires /^perl(base)$/d}
+%{?filter_from_provides: %filter_from_provides /^perl(t::.*)$/d}
 %{?perl_default_filter}
 
 %description
@@ -26,19 +26,23 @@ it can find it. Do not use this package directly, use Class::C3 instead.
 %prep
 %setup -q -n Class-C3-XS-%{version}
 
+# Filter bogus provides and requires if we don't have %%{perl_default_filter}
+%global provfilt /bin/sh -c "%{__perl_provides} | grep -v '^perl(t::'"
+%define __perl_provides %{provfilt}
+%global reqfilt /bin/sh -c "%{__perl_requires} | grep -Fvx 'perl(base)'"
+%define __perl_requires %{reqfilt}
+
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
 rm -rf %{buildroot}
-
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
+make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} \;
 find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} %{buildroot}/*
+find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
+%{_fixperms} %{buildroot}
 
 %check
 make test
@@ -49,11 +53,18 @@ rm -rf %{buildroot}
 %files
 %defattr(-,root,root,-)
 %doc ChangeLog README t/
-%{_mandir}/man3/*
-%{perl_vendorarch}/*
-%exclude %dir %{perl_vendorarch}/auto
+%{perl_vendorarch}/auto/Class/
+%{perl_vendorarch}/Class/
+%{_mandir}/man3/Class::C3::XS.3pm*
 
 %changelog
+* Wed Jan 18 2012 Paul Howarth <paul at city-fan.org> - 0.13-8
+- BR: perl(Sub::Name) for testing
+- Make %%files list more explicit
+- Filter unwanted requires and provides
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Use tabs
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.13-7
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -64,24 +75,24 @@ rm -rf %{buildroot}
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Wed Dec 15 2010 Marcela Maslanova <mmaslano at redhat.com> - 0.13-4
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Fri Apr 30 2010 Marcela Maslanova <mmaslano at redhat.com> - 0.13-3
 - Mass rebuild with perl-5.12.0
 
 * Mon Dec  7 2009 Stepan Kasal <skasal at redhat.com> - 0.13-2
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
 
-* Sat Sep 26 2009 Chris Weyl <cweyl at alumni.drew.edu> 0.13-1
-- update filtering
-- auto-update to 0.13 (by cpan-spec-update 0.01)
-- altered br on perl(ExtUtils::MakeMaker) (0 => 6.42)
+* Sat Sep 26 2009 Chris Weyl <cweyl at alumni.drew.edu> - 0.13-1
+- Update filtering
+- Auto-update to 0.13 (by cpan-spec-update 0.01)
+- Altered br on perl(ExtUtils::MakeMaker) (0 => 6.42)
 
 * Sat Jul 25 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.11-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
 
-* Thu Apr 02 2009 Chris Weyl <cweyl at alumni.drew.edu> 0.11-1
-- update to 0.11
+* Thu Apr 02 2009 Chris Weyl <cweyl at alumni.drew.edu> - 0.11-1
+- Update to 0.11
 
 * Sat Feb 28 2009 Chris Weyl <cweyl at alumni.drew.edu> - 0.08-6
 - Stripping bad provides of private Perl extension libs
@@ -90,28 +101,28 @@ rm -rf %{buildroot}
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
 * Tue Mar  4 2008 Tom "spot" Callaway <tcallawa at redhat.com> - 0.08-4
-- rebuild for new perl
+- Rebuild for new perl
 
 * Mon Feb 18 2008 Fedora Release Engineering <rel-eng at fedoraproject.org> - 0.08-3
 - Autorebuild for GCC 4.3
 
-* Tue Aug 21 2007 Chris Weyl <cweyl at alumni.drew.edu> 0.08-2
-- bump
+* Tue Aug 21 2007 Chris Weyl <cweyl at alumni.drew.edu> - 0.08-2
+- Bump
 
-* Thu Aug 09 2007 Chris Weyl <cweyl at alumni.drew.edu> 0.08-1
-- update to 0.08
+* Thu Aug 09 2007 Chris Weyl <cweyl at alumni.drew.edu> - 0.08-1
+- Update to 0.08
 
-* Thu May 31 2007 Chris Weyl <cweyl at alumni.drew.edu> 0.06-1
-- update to 0.06-1
+* Thu May 31 2007 Chris Weyl <cweyl at alumni.drew.edu> - 0.06-1
+- Update to 0.06
 
-* Sun May 13 2007 Chris Weyl <cweyl at alumni.drew.edu> 0.04-1
-- update to 0.04
+* Sun May 13 2007 Chris Weyl <cweyl at alumni.drew.edu> - 0.04-1
+- Update to 0.04
 
-* Wed May 09 2007 Chris Weyl <cweyl at alumni.drew.edu> 0.03-2
-- bump
+* Wed May 09 2007 Chris Weyl <cweyl at alumni.drew.edu> - 0.03-2
+- Bump
 
-* Wed May 09 2007 Chris Weyl <cweyl at alumni.drew.edu> 0.03-1
-- update to 0.03
+* Wed May 09 2007 Chris Weyl <cweyl at alumni.drew.edu> - 0.03-1
+- Update to 0.03
 
-* Fri May 04 2007 Chris Weyl <cweyl at alumni.drew.edu> 0.02-1
-- Specfile autogenerated by cpanspec 1.71.
+* Fri May 04 2007 Chris Weyl <cweyl at alumni.drew.edu> - 0.02-1
+- Specfile autogenerated by cpanspec 1.71



More information about the perl-devel mailing list