[perl-Class-ReturnValue] Specify all dependencies

[Petr Pisar]

On Tue, Jun 12, 2012 at 11:29:16AM +0200, Ralf Corsépius wrote:
> On 06/12/2012 11:15 AM, Petr Pisar wrote:
> >commit a4ca8b042cc0504051a24fe7e1efb7d87c86f29c
> >Author: Petr Písař<ppisar at redhat.com>
> >Date:   Tue Jun 12 11:15:22 2012 +0200
> >
> >     Specify all dependencies
> >
> >  perl-Class-ReturnValue.spec |    9 ++++++++-
> >  1 files changed, 8 insertions(+), 1 deletions(-)
> >---
> >diff --git a/perl-Class-ReturnValue.spec b/perl-Class-ReturnValue.spec
> >index ea50888..efc6e80 100644
> >--- a/perl-Class-ReturnValue.spec
> >+++ b/perl-Class-ReturnValue.spec
> >@@ -10,8 +10,13 @@ BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> >  Requires:  	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
> >  BuildArch: 	noarch
> >  Source:    	http://search.cpan.org/CPAN/authors/id/J/JE/JESSE/Class-ReturnValue-%{version}.tar.gz
> >+BuildRequires:  perl(inc::Module::Install)
> >+# Run-time
> >+BuildRequires:  perl(Carp)
> >+BuildRequires:  perl(Data::Dumper)
> >  BuildRequires:	perl(Devel::StackTrace)
> >-BuildRequires:	perl(ExtUtils::MakeMaker)
> >+BuildRequires:  perl(Exporter)
> >+# Tests
> >  BuildRequires:	perl(Test::More)
> >
> >  %description
> >@@ -19,6 +24,7 @@ A return-value object that lets you treat it as as a boolean, array or object.
> >
> >  %prep
> >  %setup -q -n Class-ReturnValue-%{version}
> >+rm -rf inc
> 
> Petr, stop this!
> 
> Forcing packages to use an external inc:Module::Install instead of
> bundled versions is not helpful.
>
It's more helpful than omitting dependencies of the bundled modules.

> All you are doing is to corrupt the module's build instructions.
> 
I cannot see any breakage if the bundled modules are not customized in any
way.

-- Petr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <http://lists.fedoraproject.org/pipermail/perl-devel/attachments/20120612/72dbc10d/attachment.sig>