[perl-Module-ExtractUse] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Tue Mar 6 21:39:58 UTC 2012


commit 5e3161d81a72e76164e66d964fae610fec98d1ea
Author: Paul Howarth <paul at city-fan.org>
Date:   Tue Mar 6 20:14:38 2012 +0000

    Spec clean-up
    
    - BR: perl(Carp) and perl(version)
    - Don't use macros for commands
    - Make %files list more explicit
    - Package example
    - Drop %defattr, redundant since rpm 4.4

 perl-Module-ExtractUse.spec |   29 +++++++++++++++++------------
 1 files changed, 17 insertions(+), 12 deletions(-)
---
diff --git a/perl-Module-ExtractUse.spec b/perl-Module-ExtractUse.spec
index 4a73c7e..b5d5261 100644
--- a/perl-Module-ExtractUse.spec
+++ b/perl-Module-ExtractUse.spec
@@ -1,13 +1,14 @@
 Name:           perl-Module-ExtractUse
 Version:        0.24
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Find out what modules are used
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Module-ExtractUse/
 Source0:        http://www.cpan.org/modules/by-module/Module/Module-ExtractUse-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:      noarch
+BuildRequires:  perl(Carp)
 BuildRequires:  perl(Module::Build)
 BuildRequires:  perl(Parse::RecDescent) >= 1.94
 BuildRequires:  perl(Pod::Strip) >= 1.00
@@ -16,7 +17,8 @@ BuildRequires:  perl(Test::NoWarnings)
 BuildRequires:  perl(Test::Pod)
 BuildRequires:  perl(Test::Pod::Coverage)
 BuildRequires:  perl(UNIVERSAL::require)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires:  perl(version)
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 Module::ExtractUse is basically a Parse::RecDescent grammar to parse Perl
@@ -27,16 +29,13 @@ from CPAN) used by the parsed code.
 %setup -q -n Module-ExtractUse-%{version}
 
 %build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
 ./Build
 
 %install
 rm -rf $RPM_BUILD_ROOT
-
 ./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
 
 %check
 ./Build test
@@ -46,15 +45,21 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 rm -rf $RPM_BUILD_ROOT
 
 %files
-%defattr(-,root,root,-)
-%doc Changes README
-%dir %{perl_vendorlib}/Module
+%doc Changes README example/
+%dir %{perl_vendorlib}/Module/
 %{perl_vendorlib}/Module/ExtractUse.pm
 %dir %{perl_vendorlib}/Module/ExtractUse/
 %{perl_vendorlib}/Module/ExtractUse/Grammar.pm
-%{_mandir}/man3/*.3pm*
+%{_mandir}/man3/Module::ExtractUse.3pm*
 
 %changelog
+* Tue Mar  6 2012 Paul Howarth <paul at city-fan.org> - 0.24-2
+- BR: perl(Carp) and perl(version)
+- Don't use macros for commands
+- Make %%files list more explicit
+- Package example
+- Drop %%defattr, redundant since rpm 4.4
+
 * Mon Feb 13 2012 Daniel P. Berrange <berrange at redhat.com> - 0.24-1
 - Update to 0.24, removing previous grammar hack (rhbz #789976)
 



More information about the perl-devel mailing list