[perl-Test-NoTabs] Remove BR: perl(ExtUtils::MakeMaker). Replace bundled modules Module::Install* by BR perl(inc::Modul

[Paul Howarth]

On Tue, 23 Oct 2012 12:53:40 +0000 (UTC)
Marcela Mašláňová <mmaslano at fedoraproject.org> wrote:

> commit cee42e2d235a984ec902618240c4cb295c99ee00
> Author: Marcela Mašláňová <mmaslano at redhat.com>
> Date:   Tue Oct 23 14:53:29 2012 +0200
> 
>     Remove BR: perl(ExtUtils::MakeMaker). Replace bundled modules
> Module::Install* by BR perl(inc::Module::Install). 
>     Signed-off-by: Marcela Mašláňová <mmaslano at redhat.com>
> 
>  perl-Test-NoTabs.spec |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> ---
> diff --git a/perl-Test-NoTabs.spec b/perl-Test-NoTabs.spec
> index d3383d5..21288bc 100644
> --- a/perl-Test-NoTabs.spec
> +++ b/perl-Test-NoTabs.spec
> @@ -1,6 +1,6 @@
>  Name:		perl-Test-NoTabs
>  Version:	1.3
> -Release:	3%{?dist}
> +Release:	4%{?dist}
>  Summary:	Check the presence of tabs in your project
>  Group:		Development/Libraries
>  License:	GPL+ or Artistic
> @@ -9,9 +9,9 @@ Source0:
> http://search.cpan.org/CPAN/authors/id/B/BO/BOBTFISH/Test-NoTabs-%{vers
> BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id
> -nu) BuildArch:	noarch BuildRequires:	perl(Cwd)
> -BuildRequires:	perl(ExtUtils::MakeMaker)
>  BuildRequires:	perl(File::Spec)
>  BuildRequires:	perl(File::Temp)
> +BuildRequires:	perl(inc::Module::Install)
>  BuildRequires:	perl(Test::Builder)
>  BuildRequires:	perl(Test::More)
>  BuildRequires:	perl(Test::Pod)
> @@ -24,6 +24,9 @@ modules, etc.) for the presence of tabs.
>  
>  %prep
>  %setup -q -n Test-NoTabs-%{version}
> +rm -r inc
> +sed -i -e '/^inc\// d' MANIFEST
> +find -type f -exec chmod -x {} +
>  
>  %build
>  perl Makefile.PL --skip INSTALLDIRS=vendor
> @@ -47,6 +50,10 @@ rm -rf %{buildroot}
>  %{_mandir}/man3/Test::NoTabs.3pm*
>  
>  %changelog
> +* Tue Oct 23 2012 Jitka Plesnikova <jplesnik at redhat.com> - 1.3-4
> +- Remove BR: perl(ExtUtils::MakeMaker)
> +- Replace bundled modules Module::Install* by BR
> perl(inc::Module::Install) +

Why is this being done?

What is the difference between using a bundled build tool
inc::Module::Install and using a bundled build tool like a configure
script? We don't go removing all upstream configure scripts and
regenerate them using autoconf, do we?

Paul.