[perl-Directory-Scratch] clean up spec for modern rpmbuild

Iain Arnell iarnell at fedoraproject.org
Sun Feb 17 17:35:53 UTC 2013


commit 1fce7526f086a477717aa77135343257bc894554
Author: Iain Arnell <iarnell at gmail.com>
Date:   Sun Feb 17 10:35:48 2013 -0700

    clean up spec for modern rpmbuild
    
    - skip failing t/os/mac.t (rt#83318)
    - BR String::Random for more test coverage

 perl-Directory-Scratch.spec |   21 ++++++++++++---------
 1 files changed, 12 insertions(+), 9 deletions(-)
---
diff --git a/perl-Directory-Scratch.spec b/perl-Directory-Scratch.spec
index 07ef496..d0e2493 100644
--- a/perl-Directory-Scratch.spec
+++ b/perl-Directory-Scratch.spec
@@ -1,13 +1,12 @@
 Name:       perl-Directory-Scratch 
 Version:    0.14 
-Release:    14%{?dist}
+Release:    15%{?dist}
 # see lib/Directory/Scratch.pm (perl)
 License:    GPL+ or Artistic
 Group:      Development/Libraries
 Summary:    Self-cleaning scratch space for tests 
 Source:     http://search.cpan.org/CPAN/authors/id/J/JR/JROCKWAY/Directory-Scratch-%{version}.tar.gz 
 Url:        http://search.cpan.org/dist/Directory-Scratch
-BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 
 Requires:   perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 BuildArch:  noarch
 
@@ -20,8 +19,10 @@ BuildRequires: perl(File::Spec)
 BuildRequires: perl(File::stat)
 BuildRequires: perl(File::Temp)
 BuildRequires: perl(Path::Class)
+BuildRequires: perl(String::Random)
 BuildRequires: perl(Test::More)
 
+%{?perl_default_filter}
 
 %description
 When writing test suites for modules that operate on files, it's often 
@@ -37,14 +38,15 @@ right.
 %prep
 %setup -q -n Directory-Scratch-%{version}
 
+#see https://rt.cpan.org/Public/Bug/Display.html?id=83318
+rm -f t/os/mac.t
+
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
-rm -rf %{buildroot}
-
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
+make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
 find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
 
@@ -53,16 +55,17 @@ find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
 %check
 make test
 
-%clean
-rm -rf %{buildroot} 
-
 %files
-%defattr(-,root,root,-)
 %doc README Changes examples/
 %{perl_vendorlib}/*
 %{_mandir}/man3/*.3*
 
 %changelog
+* Sun Feb 17 2013 Iain Arnell <iarnell at gmail.com>     0.14 -15
+- clean up spec for modern rpmbuild
+- skip failing t/os/mac.t (rt#83318)
+- BR String::Random for more test coverage
+
 * Thu Feb 14 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.14-14
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
 



More information about the perl-devel mailing list