[Bug 825678] Starting SDL on console framebuffer segfaults

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=825678

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #678316|0                           |1
        is obsolete|                            |

--- Comment #7 from Petr Pisar <ppisar at redhat.com> ---
Created attachment 678331
  --> https://bugzilla.redhat.com/attachment.cgi?id=678331&action=edit
Test case

Set depth explicitly to 0.

Problem is SDL::App::new() overries 0 depth to 16 which not suitable for my
32bpp FB. Then SDL_SetVideoMode() returns NULL, but SDL::App::new() stores and
checks reference to NULL, which is never false.

Proposed fixes:

(1) The default SDL::App -depth should be 0, not 16.
(2) The check should be done on dereferenced value.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vh3elO90J6&a=cc_unsubscribe