[perl-Email-Address] Update dependencies; Modernize spec

Jitka Plesnikova jplesnik at fedoraproject.org
Wed Jun 26 11:18:17 UTC 2013


commit 1393856e5c3465d6dd0b4e55aa7274676c612cec
Author: Jitka Plesnikova <jplesnik at redhat.com>
Date:   Wed Jun 26 13:12:11 2013 +0200

    Update dependencies; Modernize spec

 perl-Email-Address.spec |   28 +++++++++++++++++-----------
 1 files changed, 17 insertions(+), 11 deletions(-)
---
diff --git a/perl-Email-Address.spec b/perl-Email-Address.spec
index 810f465..5dcbc57 100644
--- a/perl-Email-Address.spec
+++ b/perl-Email-Address.spec
@@ -1,19 +1,26 @@
 Name:           perl-Email-Address
 Version:        1.898
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        RFC 2822 Address Parsing and Creation
 
 Group:          Development/Libraries
+# Outdated FSF address reported, rt#86433
 License:        GPL+ or Artistic
 URL:            http://search.cpan.org/dist/Email-Address/
 Source0:        http://www.cpan.org/authors/id/R/RJ/RJBS/Email-Address-%{version}.tar.gz
 
 BuildArch:      noarch
+BuildRequires:  perl
+BuildRequires:  perl(Encode)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(overload)
+BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More) >= 0.47
 BuildRequires:  perl(Test::Pod) >= 1.14
 BuildRequires:  perl(Test::Pod::Coverage) >= 1.08
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires:  perl(vars)
+BuildRequires:  perl(warnings)
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This class implements a regex-based RFC 2822 parser that locates email
@@ -27,15 +34,13 @@ is to be correct, and very very fast.
 
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*
 
 
@@ -43,18 +48,19 @@ chmod -R u+w $RPM_BUILD_ROOT/*
 make test
 
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
 %files
-%defattr(-,root,root,-)
 %doc Changes LICENSE README META.json bench/
 %{perl_vendorlib}/Email/
 %{_mandir}/man3/*.3pm*
 
 
 %changelog
+* Wed Jun 26 2013 Jitka Plesnikova <jplesnik at redhat.com> - 1.898-2
+- Specify all dependencies
+- Drop %%defattr, remove %%clean section
+- Don't need to remove empty directories from the buildroot
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+
 * Fri Feb  8 2013 Tom Callaway <spot at fedoraproject.org> - 1.898-1
 - update to 1.898
 



More information about the perl-devel mailing list