[perl-Net-Amazon-EC2] Attempt at saner SPEC file formatting

Lubomir Rintel lkundrak at fedoraproject.org
Thu Oct 24 09:50:58 UTC 2013


commit 22dc39acb1f3d4125618bcb967ff7d090e06af49
Author: Lubomir Rintel <lkundrak at v3.sk>
Date:   Thu Oct 24 11:39:54 2013 +0200

    Attempt at saner SPEC file formatting
    
    I'm doing this semi-automatically across all packages I maintain, since some
    are several years old and since then several have suffered bit-rot and such.
    I'm fixing up the following:
    
    - Old RPM relics (such as %defattr, BuildRoot or %clean sections)
    - Whitespace errors (such as trailing spaces)
    - Consistent use of %{buildroot}
    - Dropping useless %{name} expansions that harm legibility
    - Consistent spacing between RPM sections
    - Bad days in %changelogs

 perl-Net-Amazon-EC2.spec |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/perl-Net-Amazon-EC2.spec b/perl-Net-Amazon-EC2.spec
index ac1fd54..ebe142b 100644
--- a/perl-Net-Amazon-EC2.spec
+++ b/perl-Net-Amazon-EC2.spec
@@ -1,12 +1,11 @@
 Summary: Perl interface to the Amazon Elastic Compute Cloud (EC2)
 Name: perl-Net-Amazon-EC2
 Version: 0.14
-Release: 11%{?dist}
+Release: 12%{?dist}
 License: GPL+ or Artistic
 Group: Development/Libraries
 URL: http://search.cpan.org/~jkim/Net-Amazon-EC2/
 Source0: http://search.cpan.org/CPAN/authors/id/J/JK/JKIM/Net-Amazon-EC2-%{version}.tar.gz
-BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 
 
 BuildArch: noarch
@@ -55,25 +54,19 @@ make %{?_smp_mflags}
 
 
 %install
-rm -rf %{buildroot}
 make pure_install PERL_INSTALL_ROOT=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
 chmod -R u+w %{buildroot}/*
 
 
 %check
-make test
-
-
-%clean
 # Avoid online tests
 set AWS_ACCESS_KEY_ID=
 set SECRET_ACCESS_KEY=
-rm -rf %{buildroot}
+make test
 
 
 %files
-%defattr(-,root,root,-)
 %doc README
 %dir %{perl_vendorlib}/Net
 %dir %{perl_vendorlib}/Net/Amazon
@@ -171,6 +164,9 @@ rm -rf %{buildroot}
 
 
 %changelog
+* Thu Oct 24 2013 Lubomir Rintel <lkundrak at v3.sk> - 0.14-12
+- Bulk sad and useless attempt at consistent SPEC file formatting
+
 * Fri Aug 02 2013 Petr Pisar <ppisar at redhat.com> - 0.14-11
 - Perl 5.18 rebuild
 - Specify all dependencies



More information about the perl-devel mailing list