[perl-Test-Pod-Coverage] Modernize spec file

Petr Pisar ppisar at fedoraproject.org
Mon Feb 17 15:12:25 UTC 2014


commit 3eef745f52a19cfd0f0445855ee76d4db929d318
Author: Petr Písař <ppisar at redhat.com>
Date:   Mon Feb 17 16:03:34 2014 +0100

    Modernize spec file

 perl-Test-Pod-Coverage.spec |   43 +++++++++++++++++++------------------------
 1 files changed, 19 insertions(+), 24 deletions(-)
---
diff --git a/perl-Test-Pod-Coverage.spec b/perl-Test-Pod-Coverage.spec
index baf64bc..7c9e775 100644
--- a/perl-Test-Pod-Coverage.spec
+++ b/perl-Test-Pod-Coverage.spec
@@ -1,62 +1,57 @@
 Name:           perl-Test-Pod-Coverage
 Version:        1.08
-Release:        21%{?dist}
+Release:        22%{?dist}
 Summary:        Check for pod coverage in your distribution
-
 Group:          Development/Libraries
 License:        GPL+ or Artistic
 URL:            http://search.cpan.org/dist/Test-Pod-Coverage/
 Source0:        http://www.cpan.org/authors/id/P/PE/PETDANCE/Test-Pod-Coverage-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-
 BuildArch:      noarch
-BuildRequires:  perl(base)
-BuildRequires:  perl(lib)
+BuildRequires:  perl
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
+# Run-time:
 BuildRequires:  perl(Pod::Coverage)
 BuildRequires:  perl(Test::Builder)
+# Tests:
+BuildRequires:  perl(base)
+BuildRequires:  perl(lib)
+BuildRequires:  perl(Pod::Coverage::CountParents)
 BuildRequires:  perl(Test::Builder::Tester)
 BuildRequires:  perl(Test::More)
-BuildRequires:  perl(Test::Pod)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+# Optional tests:
+BuildRequires:  perl(Test::Pod) >= 1.14
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 Checks for POD coverage in files for your distribution.
 
-
 %prep
 %setup -q -n Test-Pod-Coverage-%{version}
 
-
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
-
 %install
-rm -rf $RPM_BUILD_ROOT
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
-
+%{_fixperms} $RPM_BUILD_ROOT/*
 
 %check
 make test
 
-
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
 %files
-%defattr(-,root,root,-)
 %doc Changes
 %{perl_vendorlib}/Test/
 %{_mandir}/man3/*.3pm*
 
-
 %changelog
+* Mon Feb 17 2014 Petr Pisar <ppisar at redhat.com> - 1.08-22
+- Modernize spec file
+- Specify all dependencies (bug #1066046)
+
 * Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.08-21
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
 



More information about the perl-devel mailing list