[Bug 1067003] Review Request: perl-Time-ParseDate - Date parsing both relative and absolute

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1067003



--- Comment #9 from Petr Pisar <ppisar at redhat.com> ---
The standalone spec file and file from source RPM differ. I will use the
standalone one for this review.

The URL and Source0 are usable. Ok.
The source archive is original (SHA-256:
14a761a45885cbff907531a0b293a7553100260ec0aa6cb51f4deef75616cdfe). Ok.
Summary is Ok.
Description is Ok.

TODO: Wrap the description paragraph to 80 columns.

License verified from lib/Time/ParseDate.pm, lib/Time/CTime.pm,
lib/Time/DaysInMonth.pm, lib/Time/JulianDay.pm, lib/Time/Timezone.pm.

FIX: The lib/Time/Timezone.pm is not TPDL-licensed. It is "Public Domain":

=head1 LICENSE

David Muir Sharnoff disclaims any copyright and puts his contribution
to this module in the public domain.

Change the license tag from (TPDL) to (TPDL and Public Domain).

No XS code presents, noarch BuildArch is Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-Time-ParseDate.spec
../SRPMS/perl-Time-ParseDate-2013.1113-2.fc21.src.rpm
../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm 
perl-Time-ParseDate.src: W: spelling-error %description -l en_US CTime -> C
Time, Crime, Clime
perl-Time-ParseDate.src: W: spelling-error %description -l en_US DaysInMonth ->
Semimonthly
perl-Time-ParseDate.src: W: spelling-error %description -l en_US JulianDay ->
Julian Day, Julian-Day, Julian-day
perl-Time-ParseDate.src: E: description-line-too-long C There can be numerous
options for controlling what is recognized and what is not.
perl-Time-ParseDate.noarch: W: spelling-error %description -l en_US CTime -> C
Time, Crime, Clime
perl-Time-ParseDate.noarch: W: spelling-error %description -l en_US DaysInMonth
-> Semimonthly
perl-Time-ParseDate.noarch: W: spelling-error %description -l en_US JulianDay
-> Julian Day, Julian-Day, Julian-day
perl-Time-ParseDate.noarch: E: description-line-too-long C There can be
numerous options for controlling what is recognized and what is not.
2 packages and 1 specfiles checked; 2 errors, 6 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul  1 15:02
/usr/share/doc/perl-Time-ParseDate
-rw-r--r--    1 root    root                     7275 Nov 14  2013
/usr/share/doc/perl-Time-ParseDate/Changes
-rw-r--r--    1 root    root                      604 Nov 28  1998
/usr/share/doc/perl-Time-ParseDate/README
-rw-r--r--    1 root    root                     2805 Jul  1 15:02
/usr/share/man/man3/Time::CTime.3pm.gz
-rw-r--r--    1 root    root                     2181 Jul  1 15:02
/usr/share/man/man3/Time::DaysInMonth.3pm.gz
-rw-r--r--    1 root    root                     2901 Jul  1 15:02
/usr/share/man/man3/Time::JulianDay.3pm.gz
-rw-r--r--    1 root    root                     3674 Jul  1 15:02
/usr/share/man/man3/Time::ParseDate.3pm.gz
-rw-r--r--    1 root    root                     2321 Jul  1 15:02
/usr/share/man/man3/Time::Timezone.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul  1 15:02
/usr/share/perl5/vendor_perl/Time
-rw-r--r--    1 root    root                     5780 Sep 20  2013
/usr/share/perl5/vendor_perl/Time/CTime.pm
-rw-r--r--    1 root    root                     1330 Apr  1  2008
/usr/share/perl5/vendor_perl/Time/DaysInMonth.pm
-rw-r--r--    1 root    root                     5940 May  6  2011
/usr/share/perl5/vendor_perl/Time/JulianDay.pm
-rw-r--r--    1 root    root                    29907 Nov 14  2013
/usr/share/perl5/vendor_perl/Time/ParseDate.pm
-rw-r--r--    1 root    root                     9604 Sep 20  2013
/usr/share/perl5/vendor_perl/Time/Timezone.pm
File permissions and layout is Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm | sort -f | uniq
-c
      1 perl >= 0:5.000
      1 perl >= 0:5.002
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(integer)
      1 perl(strict)
      1 perl(Time::CTime)
      1 perl(Time::JulianDay)
      1 perl(Time::Timezone)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm | sort -f | uniq
-c
      1 perl(Time::CTime) = 2011.0505
      1 perl(Time::DaysInMonth) = 99.1117
      1 perl(Time::JulianDay) = 2011.0505
      1 perl(Time::ParseDate) = 2013.1113
      1 perl(Time::Timezone) = 2006.0814
      1 perl-Time-modules = 2013.1113-2.fc21
      1 perl-Time-ParseDate = 2013.1113-2.fc21
Binary provides are Ok.

This package replaces perl-Time-modules correctly. Ok.

Package builds in F21
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7096282). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' issues, consider fixing `TODO' items, and provide new
spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pcXztxTVgj&a=cc_unsubscribe