[perl-Net-Amazon-S3] Enable s3cl tool

Petr Pisar ppisar at fedoraproject.org
Thu Mar 27 16:05:23 UTC 2014


commit 94ce32ee4e8d6200b94b89badcfcd41214c0000d
Author: Petr Písař <ppisar at redhat.com>
Date:   Thu Mar 27 13:48:11 2014 +0100

    Enable s3cl tool
    
    And modernize spec files etc.

 .rpmlint                |    2 +
 perl-Net-Amazon-S3.spec |  152 ++++++++++++-----------------------------------
 2 files changed, 40 insertions(+), 114 deletions(-)
---
diff --git a/.rpmlint b/.rpmlint
new file mode 100644
index 0000000..7d0c218
--- /dev/null
+++ b/.rpmlint
@@ -0,0 +1,2 @@
+from Config import *
+addFilter("spelling-error .* (amazonaws|http|scalable)");
diff --git a/perl-Net-Amazon-S3.spec b/perl-Net-Amazon-S3.spec
index b32ede4..c76e3ba 100644
--- a/perl-Net-Amazon-S3.spec
+++ b/perl-Net-Amazon-S3.spec
@@ -1,77 +1,58 @@
-# Noarch packages don't generate any debuginfo
-%global debug_package %{nil}
-
-Summary: Use the Amazon Simple Storage Service (S3)
-Name: perl-Net-Amazon-S3
-Version: 0.59
-Release: 1%{?dist}
-License: GPL+ or Artistic
-Group: Development/Libraries
-URL: http://search.cpan.org/dist/Net-Amazon-S3/
-Source0: http://search.cpan.org/CPAN/authors/id/P/PF/PFIG/Net-Amazon-S3-%{version}.tar.gz
-BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
-
-BuildArch: noarch
-# Module Build
+Summary:    Use the Amazon Simple Storage Service (S3)
+Name:       perl-Net-Amazon-S3
+Version:    0.59
+Release:    2%{?dist}
+License:    GPL+ or Artistic
+Group:      Development/Libraries
+URL:        http://search.cpan.org/dist/Net-Amazon-S3/
+Source0:    http://search.cpan.org/CPAN/authors/id/P/PF/PFIG/Net-Amazon-S3-%{version}.tar.gz
+BuildArch:  noarch
 BuildRequires: perl
 BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30
-# Module Runtime
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
+# Run-time:
 BuildRequires: perl(Carp)
 BuildRequires: perl(Data::Stream::Bulk::Callback)
 BuildRequires: perl(DateTime::Format::HTTP)
 BuildRequires: perl(Digest::HMAC_SHA1)
 BuildRequires: perl(Digest::MD5)
 BuildRequires: perl(Digest::MD5::File)
+BuildRequires: perl(File::Find::Rule)
 BuildRequires: perl(File::stat)
+BuildRequires: perl(Getopt::Long)
 BuildRequires: perl(HTTP::Date)
 BuildRequires: perl(HTTP::Status)
 BuildRequires: perl(IO::File) >= 1.14
 BuildRequires: perl(LWP::UserAgent::Determined)
 BuildRequires: perl(MIME::Base64)
+BuildRequires: perl(MIME::Types)
 BuildRequires: perl(Moose) >= 0.85
 BuildRequires: perl(Moose::Util::TypeConstraints)
 BuildRequires: perl(MooseX::StrictConstructor) >= 0.16
 BuildRequires: perl(MooseX::Types::DateTime::MoreCoercions) >= 0.07
+BuildRequires: perl(Path::Class)
+BuildRequires: perl(Pod::Usage)
 BuildRequires: perl(Regexp::Common)
+# Term::Encoding is optional
+BuildRequires: perl(Term::ProgressBar::Simple)
 BuildRequires: perl(URI)
 BuildRequires: perl(URI::Escape)
 BuildRequires: perl(URI::QueryParam)
 BuildRequires: perl(XML::LibXML)
 BuildRequires: perl(XML::LibXML::XPathContext)
-# Requirements of s3cl (some not yet in Fedora, so we exclude the script for now)
-BuildRequires: perl(File::Find::Rule)
-BuildRequires: perl(Getopt::Long)
-BuildRequires: perl(MIME::Types)
-BuildRequires: perl(Path::Class)
-BuildRequires: perl(Pod::Usage)
-BuildRequires: perl(strict)
-#BuildRequires: perl(Term::Encoding)
-#BuildRequires: perl(Term::ProgressBar::Simple)
-BuildRequires: perl(warnings)
-# Test Suite
+# Tests:
+# English not used
 BuildRequires: perl(File::Find)
 BuildRequires: perl(File::Temp)
+BuildRequires: perl(lib)
 BuildRequires: perl(LWP::Simple)
 BuildRequires: perl(Test::Exception)
 BuildRequires: perl(Test::More)
 BuildRequires: perl(vars)
-# Release Tests
-# CHANGES file should be called Changes before t/release-cpan-changes.t can work
-#BuildRequires: perl(Test::CPAN::Changes)
-BuildRequires: perl(Test::CPAN::Meta)
-BuildRequires: perl(Test::CPAN::Meta::JSON)
-BuildRequires: perl(Test::DistManifest)
-BuildRequires: perl(Test::MinimumVersion)
-BuildRequires: perl(Test::Mojibake)
-BuildRequires: perl(Test::NoTabs)
-BuildRequires: perl(Test::Pod) >= 1.41
-BuildRequires: perl(Test::Portability::Files)
-BuildRequires: perl(Test::Synopsis)
-BuildRequires: perl(Test::Vars)
-BuildRequires: perl(Test::Version)
-# Runtime
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-
+# Optional tests:
+BuildRequires: perl(Test::Script) >= 1.05
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This module provides a Perlish interface to Amazon S3. From the
@@ -84,96 +65,39 @@ inexpensive data storage infrastructure that Amazon uses to run its own
 global network of web sites. The service aims to maximize benefits of
 scale and to pass those benefits on to developers".
 
-To find out more about S3, please visit: http://s3.amazonaws.com/
+To find out more about S3, please visit <http://s3.amazonaws.com/>.
 
 
 %prep
 %setup -q -n Net-Amazon-S3-%{version}
-
 # Get rid of unnecessary exec bits
-find lib -name '*.pm' -exec chmod -c -x {} ';'
-
+find lib -name '*.pm' -exec chmod -c -x {} +
+# Fix shebang
+sed -i -e '1 s|^#!.*|#!%{__perl}|' bin/s3cl
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
-
 %install
-rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
 %{_fixperms} %{buildroot}
 
-
 %check
-make test RELEASE_TESTING=1
-
-
-%clean
-rm -rf %{buildroot}
-
+make test
 
 %files
 %doc CHANGES LICENSE README
-%exclude %{_bindir}/s3cl
-%dir %{perl_vendorlib}/Net
-%dir %{perl_vendorlib}/Net/Amazon
-%dir %{perl_vendorlib}/Net/Amazon/S3
-%dir %{perl_vendorlib}/Net/Amazon/S3/Client
-%dir %{perl_vendorlib}/Net/Amazon/S3/Request
-%{perl_vendorlib}/Net/Amazon/S3.pm
-%{perl_vendorlib}/Net/Amazon/S3/Bucket.pm
-%{perl_vendorlib}/Net/Amazon/S3/Client.pm
-%{perl_vendorlib}/Net/Amazon/S3/Client/Bucket.pm
-%{perl_vendorlib}/Net/Amazon/S3/Client/Object.pm
-%{perl_vendorlib}/Net/Amazon/S3/HTTPRequest.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/CompleteMultipartUpload.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/CreateBucket.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/DeleteBucket.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/DeleteMultiObject.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/DeleteObject.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/GetBucketAccessControl.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/GetBucketLocationConstraint.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/GetObject.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/GetObjectAccessControl.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/InitiateMultipartUpload.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/ListAllMyBuckets.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/ListBucket.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/ListParts.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/PutObject.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/PutPart.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/SetBucketAccessControl.pm
-%{perl_vendorlib}/Net/Amazon/S3/Request/SetObjectAccessControl.pm
-%exclude %{_mandir}/man1/s3cl.1*
-%{_mandir}/man3/Net::Amazon::S3.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Bucket.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Client.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Client::Bucket.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Client::Object.3pm*
-%{_mandir}/man3/Net::Amazon::S3::HTTPRequest.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::CompleteMultipartUpload.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::CreateBucket.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::DeleteBucket.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::DeleteMultiObject.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::DeleteObject.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::GetBucketAccessControl.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::GetBucketLocationConstraint.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::GetObject.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::GetObjectAccessControl.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::InitiateMultipartUpload.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::ListAllMyBuckets.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::ListBucket.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::ListParts.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::PutObject.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::PutPart.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::SetBucketAccessControl.3pm*
-%{_mandir}/man3/Net::Amazon::S3::Request::SetObjectAccessControl.3pm*
-
+%{_bindir}/*
+%{perl_vendorlib}/*
+%{_mandir}/man1/*
+%{_mandir}/man3/*
 
 %changelog
+* Thu Mar 27 2014 Petr Pisar <ppisar at redhat.com> - 0.59-2
+- Enable s3cl tool (bug #995748)
+
 * Sat Aug 10 2013 Paul Howarth <paul at city-fan.org> - 0.59-1
 - Update to 0.59
 - This release by PFIG -> update source URL



More information about the perl-devel mailing list