[Bug 1152319] perl-Module-Starter produces invalid license identifiers

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1152319



--- Comment #5 from Richard Poole <rp at guests.deus.net> ---
The patch you've applied fixes the case where Software::License is not
installed at the expense of breaking the case where Software::License *is*
installed - it changes the values of the field called "slname", which is used
in Module::Build, later in the build process, as the name of the license as
Software::License thinks of it. (This is why the field is called "slname".)

The patched version works for the artistic license version 2 but breaks several
other licenses, including the Perl license and the GPL. As most module authors
will have Software::License installed and the most commonly used license is the
Perl license, this will in practice break the majority of installations.

I think the best fix of all would be for Module::Starter to require
Software::License and use it for its license-related logic; Software::License
is capable of checking strings for compliance with CPAN::Meta , among other
things. But that involves rather more work. I stand by my original suggestion,
that Module::Starter should be distributed in Fedora without this patch but
with a dependency on Software::License. That won't break anything that
currently works and will make a significant class of confusing errors
impossible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AGc08khuLB&a=cc_unsubscribe