jplesnik pushed to perl-DB_File-Lock (master). "Fix RT#98224"

notifications at fedoraproject.org notifications at fedoraproject.org
Thu Apr 23 08:34:20 UTC 2015


>From 75d37a2c2babc3396e6763e87db5032230546074 Mon Sep 17 00:00:00 2001
From: Jitka Plesnikova <jplesnik at redhat.com>
Date: Thu, 23 Apr 2015 10:34:08 +0200
Subject: Fix RT#98224


diff --git a/DB_File-Lock-0.05-RT98224.patch b/DB_File-Lock-0.05-RT98224.patch
new file mode 100644
index 0000000..6826daf
--- /dev/null
+++ b/DB_File-Lock-0.05-RT98224.patch
@@ -0,0 +1,29 @@
+From 247a7ec3a57f2bca977531281f258d5e4ed46c1f Mon Sep 17 00:00:00 2001
+From: Slaven Rezic <slaven at rezic.de>
+Date: Thu, 21 Aug 2014 19:54:41 +0200
+Subject: [PATCH] don't use defined %hash
+
+This fixes https://rt.cpan.org/Ticket/Display.html?id=98224
+---
+ test.pl | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+ mode change 100644 => 100755 test.pl
+
+diff --git a/test.pl b/test.pl
+old mode 100644
+new mode 100755
+index 92ebcf6..cba6da6
+--- a/test.pl
++++ b/test.pl
+@@ -81,7 +81,7 @@ if ( not defined $pid ) {
+ 	sleep(1);
+ 	$TEST_NUM += 2;
+ 	report_result( not tie %hash3, 'DB_File::Lock', $file1, O_RDWR, 0600, $DB_HASH, $nonblock_write );
+-	report_result( not defined %hash3 ); # double check and satisfy -w about %hash3
++	report_result( not keys %hash3 ); # double check and satisfy -w about %hash3
+ 	$TEST_NUM += 1;
+ 	report_result( wait() == $pid );
+ 	report_result( tie %hash3, 'DB_File::Lock', $file1, O_RDWR, 0600, $DB_HASH, $nonblock_write );
+-- 
+1.8.3.4
+
diff --git a/perl-DB_File-Lock.spec b/perl-DB_File-Lock.spec
index 6ce66ed..d11846c 100644
--- a/perl-DB_File-Lock.spec
+++ b/perl-DB_File-Lock.spec
@@ -1,11 +1,13 @@
 Name:           perl-DB_File-Lock
 Version:        0.05
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Locking with flock wrapper for DB_File
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/DB_File-Lock/
 Source0:        http://www.cpan.org/modules/by-module/DB_File/DB_File-Lock-%{version}.tar.gz
+# defined() should not be used for hash RT#98224
+Patch1:         DB_File-Lock-0.05-RT98224.patch
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(Carp)
@@ -23,6 +25,7 @@ This module provides a wrapper for the DB_File module, adding locking.
 
 %prep
 %setup -q -n DB_File-Lock-%{version}
+%patch1 -p1
 
 
 %build
@@ -31,7 +34,7 @@ make %{?_smp_mflags}
 
 
 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
 %{_fixperms} $RPM_BUILD_ROOT/*
 
@@ -47,6 +50,9 @@ make test
 
 
 %changelog
+* Thu Apr 23 2015 Jitka Plesnikova <jplesnik at redhat.com> - 0.05-5
+- Fix RT#98224
+
 * Wed Aug 27 2014 Jitka Plesnikova <jplesnik at redhat.com> - 0.05-4
 - Perl 5.20 rebuild
 
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/perl-DB_File-Lock.git/commit/?h=master&id=75d37a2c2babc3396e6763e87db5032230546074


More information about the perl-devel mailing list