psabata pushed to perl-Makefile-Parser (master). "Prevent FTBFS by correcting the build time dependency list (..more)"

notifications at fedoraproject.org notifications at fedoraproject.org
Tue Aug 11 14:20:56 UTC 2015


From 9e9e4e97390ea660f6091dfd62c5427679353aba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20=C5=A0abata?= <contyk at redhat.com>
Date: Tue, 11 Aug 2015 16:20:49 +0200
Subject: Prevent FTBFS by correcting the build time dependency list

- The dep list is quite long and ugly; most of it comes from the bundled
  modules (Module::AutoInstall, Module::Install, Spiffy, Test::Base,
  Test::Builder, Test::More) -- it'd be much better to simply unbundle them
- Enable most of the test suite; the failing test is most likely fixed
  in the new upstream version -- an update is advised

diff --git a/perl-Makefile-Parser.spec b/perl-Makefile-Parser.spec
index 2fc1688..cb860da 100644
--- a/perl-Makefile-Parser.spec
+++ b/perl-Makefile-Parser.spec
@@ -1,6 +1,6 @@
 Name:           perl-Makefile-Parser
 Version:        0.211
-Release:        16%{?dist}
+Release:        17%{?dist}
 Summary:        Simple parser for Makefiles
 License:        GPL+ or Artistic
 Group:          Development/Libraries
@@ -8,24 +8,52 @@ URL:            http://search.cpan.org/dist/Makefile-Parser/
 Source0:        http://www.cpan.org/authors/id/A/AG/AGENT/Makefile-Parser-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
-BuildRequires:  perl >= 1:5.6.1
+BuildRequires:  coreutils
+BuildRequires:  findutils
+BuildRequires:  make
+BuildRequires:  sed
+BuildRequires:  perl
+BuildRequires:  perl(base)
+BuildRequires:  perl(Carp)
 BuildRequires:  perl(Class::Accessor::Fast)
 BuildRequires:  perl(Class::Trigger) >= 0.13
+BuildRequires:  perl(Config)
+BuildRequires:  perl(CPAN)
+BuildRequires:  perl(Cwd)
+BuildRequires:  perl(Data::Dumper)
+BuildRequires:  perl(Exporter)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MM_Unix)
+BuildRequires:  perl(File::Basename)
+BuildRequires:  perl(File::Find)
+BuildRequires:  perl(File::Path)
 BuildRequires:  perl(File::Slurp)
+BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(File::stat)
+BuildRequires:  perl(File::Temp)
+BuildRequires:  perl(Filter::Util::Call)
+BuildRequires:  perl(FindBin)
+BuildRequires:  perl(Getopt::Long)
 BuildRequires:  perl(IPC::Run3) >= 0.036
+BuildRequires:  perl(lib)
 BuildRequires:  perl(List::MoreUtils)
-BuildRequires:  perl(Makefile::DOM) >= 0.003
-BuildRequires:  perl(Test::More)
+BuildRequires:  perl(List::Util)
+BuildRequires:  perl(MDOM::Document::Gmake)
+BuildRequires:  perl(MDOM::Util)
+BuildRequires:  perl(overload)
+BuildRequires:  perl(Scalar::Util)
+BuildRequires:  perl(strict)
 BuildRequires:  perl(Text::Balanced)
-Requires:       perl(Class::Accessor::Fast)
+BuildRequires:  perl(Text::Diff)
+BuildRequires:  perl(threads::shared)
+BuildRequires:  perl(Time::HiRes)
+BuildRequires:  perl(vars)
+BuildRequires:  perl(warnings)
 Requires:       perl(Class::Trigger) >= 0.13
-Requires:       perl(File::Slurp)
-Requires:       perl(List::MoreUtils)
-Requires:       perl(Makefile::DOM) >= 0.003
-Requires:       perl(Text::Balanced)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
+%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(Class::Trigger\\)$
+
 %description
 This is a simple parser for Makefiles. At this very early stage, the parser
 only supports a limited set of features, so it may not recognize most of
@@ -37,6 +65,8 @@ satisfactory for this purpose, so I decided to build one of my own.
 
 %prep
 %setup -q -n Makefile-Parser-%{version}
+# This test is fishy; and yes, it needs to be done here
+rm t/makesimple.t && sed -e '/^t\/makesimple\.t/d' MANIFEST
 
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
@@ -52,8 +82,9 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 
 %{_fixperms} $RPM_BUILD_ROOT/*
 
-#%check
-#make test
+%check
+# makesimple.t is disabled, see the %%prep section
+make test
 
 %clean
 rm -rf $RPM_BUILD_ROOT
@@ -69,6 +100,14 @@ rm -rf $RPM_BUILD_ROOT
 %{_bindir}/plmake
 
 %changelog
+* Tue Aug 11 2015 Petr Ĺ abata <contyk at redhat.com> - 0.211-17
+- Prevent FTBFS by correcting the build time dependency list
+- The dep list is quite long and ugly; most of it comes from the bundled
+  modules (Module::AutoInstall, Module::Install, Spiffy, Test::Base,
+  Test::Builder, Test::More) -- it'd be much better to simply unbundle them
+- Enable most of the test suite; the failing test is most likely fixed
+  in the new upstream version -- an update is advised
+
 * Thu Jun 18 2015 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.211-16
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
 
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/perl-Makefile-Parser.git/commit/?h=master&id=9e9e4e97390ea660f6091dfd62c5427679353aba


More information about the perl-devel mailing list