[perl-DBD-Pg] Remove tests sub-package, tests don't work without Makefile

Jitka Plesnikova jplesnik at fedoraproject.org
Wed Feb 11 14:36:07 UTC 2015


commit e932ceca7ae391d49c87f6cd8f2835fe63784465
Author: Jitka Plesnikova <jplesnik at redhat.com>
Date:   Wed Feb 11 15:35:27 2015 +0100

    Remove tests sub-package, tests don't work without Makefile

 perl-DBD-Pg.spec |   44 +++++++++++++-------------------------------
 1 files changed, 13 insertions(+), 31 deletions(-)
---
diff --git a/perl-DBD-Pg.spec b/perl-DBD-Pg.spec
index 7c4e24d..58b0b2d 100644
--- a/perl-DBD-Pg.spec
+++ b/perl-DBD-Pg.spec
@@ -23,31 +23,18 @@ BuildRequires:  perl(DynaLoader)
 BuildRequires:  perl(Exporter)
 BuildRequires:  perl(version)
 # Tests:
-%tests_req perl(charnames)
-%tests_req perl(constant)
-%tests_req perl(Cwd)
-%tests_req perl(Data::Dumper)
-%tests_req perl(Test::More) >= 0.88
-%tests_req perl(Test::Simple)
-%tests_req perl(Time::HiRes)
-%tests_req perl(utf8)
-%tests_req postgresql-server
+BuildRequires:  perl(charnames)
+BuildRequires:  perl(constant)
+BuildRequires:  perl(Cwd)
+BuildRequires:  perl(Data::Dumper)
+BuildRequires:  perl(Test::More) >= 0.88
+BuildRequires:  perl(Test::Simple)
+BuildRequires:  perl(Time::HiRes)
+BuildRequires:  perl(utf8)
+BuildRequires:  postgresql-server
 # Optional tests:
-%tests_req perl(Encode)
-%tests_req perl(File::Temp)
-# test sub-package requirements
-%tests_subpackage_requires perl(Carp)
-%tests_subpackage_requires perl(Config)
-%tests_subpackage_requires perl(Data::Peek)
-%tests_subpackage_requires perl(DBD::Pg)
-%tests_subpackage_requires perl(DBI)
-%tests_subpackage_requires perl(Devel::Leak)
-%tests_subpackage_requires perl(File::Spec)
-%tests_subpackage_requires perl(lib)
-%tests_subpackage_requires perl(strict)
-%tests_subpackage_requires perl(vars)
-%tests_subpackage_requires perl(warnings)
-%tests_subpackage_requires perl(YAML)
+BuildRequires:  perl(Encode)
+BuildRequires:  perl(File::Temp)
 
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 Requires:       perl(DBI) >= 1.614
@@ -58,7 +45,6 @@ Provides:       perl(DBD::Pg) = %{version}
 %{?perl_default_filter}
 %global __provides_exclude %{?__provides_exclude:%__provides_exclude|}^perl\\(DBD::Pg\\)$
 %global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(DBI\\)$
-%{?perl_default_subpackage_tests}
 
 %description
 DBD::Pg is a Perl module that works with the DBI module to provide access
@@ -66,20 +52,15 @@ to PostgreSQL databases.
 
 %prep
 %setup -q -n DBD-Pg-%{version}
-# Move testme.tmp.pl into tests sub-package
-mv testme.tmp.pl t/
-sed -i -e '/^testme.tmp.pl$/ s/^/t\//' MANIFEST
-sed -i -e '1 s/#!.*//' t/testme.tmp.pl
 
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
 make %{?_smp_mflags}
 
 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*
 
 %check
@@ -101,6 +82,7 @@ make test
 %changelog
 * Wed Feb 11 2015 Jitka Plesnikova <jplesnik at redhat.com> - 3.5.0-1
 - 3.5.0 bump
+- Remove tests sub-package, tests don't work without Makefile
 
 * Mon Sep 29 2014 Jitka Plesnikova <jplesnik at redhat.com> - 3.4.2-1
 - 3.4.2 bump



More information about the perl-devel mailing list