[Bug 1195573] Review Request: dropbox-api-command - Dropbox API wrapper command

Wed Feb 25 00:35:54 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1195573

Victoria Martinez de la Cruz <vimartin at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vimartin at redhat.com

--- Comment #2 from Victoria Martinez de la Cruz <vimartin at redhat.com> ---
This is an unofficial review only.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
=======
- Dirs in package are owned also by: /usr/share/perl5/App(perl)

http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/perl5/App(perl)
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: dropbox-api-command-1.17-1.fc23.noarch.rpm
          dropbox-api-command-1.17-1.fc23.src.rpm
dropbox-api-command.noarch: W: no-version-in-last-changelog
dropbox-api-command.noarch: W: no-manual-page-for-binary dropbox-api
dropbox-api-command.noarch: W: no-manual-page-for-binary upload-to-dropbox
dropbox-api-command.src: W: no-version-in-last-changelog
dropbox-api-command.src: W: strange-permission
dropbox-api-command-446e6e382f7e79744549f72436cd5407cefac8db.tar.gz 0640L
dropbox-api-command.src: W: strange-permission dropbox-api-command.spec 0640L
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

Requires
--------
dropbox-api-command (rpmlib, GLIBC filtered):
    /bin/bash
    /usr/bin/env
    perl(:MODULE_COMPAT_5.20.2)
    perl(Cwd)
    perl(Data::Dumper)
    perl(DateTime)
    perl(DateTime::Format::Strptime)
    perl(Encode)
    perl(Encode::Locale)
    perl(File::Basename)
    perl(File::Spec::Functions)
    perl(File::Temp)
    perl(Getopt::Std)
    perl(JSON)
    perl(Path::Class)
    perl(WebService::Dropbox)
    perl(strict)
    perl(warnings)

Provides
--------
dropbox-api-command:
    dropbox-api-command
    perl(App::dropboxapi)

Source checksums
----------------
https://github.com/s-aska/dropbox-api-command/archive/446e6e382f7e79744549f72436cd5407cefac8db/dropbox-api-command-446e6e382f7e79744549f72436cd5407cefac8db.tar.gz
:
  CHECKSUM(SHA256) this package     :
afd1d29ab50383cf851ee0afffa15c0546182484ec9e8dd248c5cc58143137e5
  CHECKSUM(SHA256) upstream package :
afd1d29ab50383cf851ee0afffa15c0546182484ec9e8dd248c5cc58143137e5

Command line :/usr/bin/fedora-review -b 1195573 --mock-config
fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Perl
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jn71V8yxCg&a=cc_unsubscribe