ppisar pushed to perl-XML-LibXML (master). "Disable thread tests because thread support not complete (..more)"

notifications at fedoraproject.org notifications at fedoraproject.org
Wed May 27 11:58:09 UTC 2015


From 3bb553b0debeeeea9855595ab79b5f149215d315 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar at redhat.com>
Date: Wed, 27 May 2015 13:46:55 +0200
Subject: Disable thread tests because thread support not complete

Set the THREAD_TEST variable to 0 explicitly in order not to be
influenced by environment that the rpmbuild is executed in.

diff --git a/perl-XML-LibXML.spec b/perl-XML-LibXML.spec
index 7d08d8e..d3101c7 100644
--- a/perl-XML-LibXML.spec
+++ b/perl-XML-LibXML.spec
@@ -1,10 +1,14 @@
+# Do not invoke thread tests by default because the thread support is broken,
+# bug #1224731, CPAN RT#91800
+%bcond_with thread_test
+
 Name:           perl-XML-LibXML
 # NOTE: also update perl-XML-LibXSLT to a compatible version, see
 # https://bugzilla.redhat.com/show_bug.cgi?id=469480
 # it might not be needed anymore
 # this module is maintained, the other is not
 Version:        2.0121
-Release:        1%{?dist}
+Release:        2%{?dist}
 Epoch:          1
 Summary:        Perl interface to the libxml2 library
 Group:          Development/Libraries
@@ -57,8 +61,10 @@ BuildRequires:  perl(Test::LeakTrace)
 %endif
 BuildRequires:  perl(Test::Pod) >= 1.14
 # Optional Test::TrailingSpace
+%if %{with thread_test}
 BuildRequires:  perl(threads)
 BuildRequires:  perl(threads::shared)
+%endif
 BuildRequires:  perl(URI::file)
 BuildRequires:  perl(utf8)
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
@@ -95,7 +101,7 @@ find %{buildroot} -type f -name '*.bs' -empty -exec rm -f {} ';'
 chmod -R u+w %{buildroot}/*
 
 %check
-THREAD_TEST=1 make test
+THREAD_TEST=0%{?with_thread_test:1} make test
 
 %triggerin -- perl-XML-SAX
 for p in XML::LibXML::SAX::Parser XML::LibXML::SAX ; do
@@ -119,6 +125,9 @@ fi
 %{_mandir}/man3/*.3*
 
 %changelog
+* Wed May 27 2015 Petr Pisar <ppisar at redhat.com> - 1:2.0121-2
+- Disable thread tests because thread support not complete (bug #1224731)
+
 * Mon May 04 2015 Jitka Plesnikova <jplesnik at redhat.com> - 1:2.0121-1
 - 2.0121 bump
 
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/perl-XML-LibXML.git/commit/?h=master&id=3bb553b0debeeeea9855595ab79b5f149215d315


More information about the perl-devel mailing list