jplesnik pushed to perl-Devel-Cover (f23). "Specify all dependencies (..more)"

notifications at fedoraproject.org notifications at fedoraproject.org
Mon Sep 21 15:18:44 UTC 2015


From 92a47735129646bb15c056aa9641f80968bd8346 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar at redhat.com>
Date: Wed, 22 Jul 2015 14:07:44 +0200
Subject: Specify all dependencies

A test was failing without Math::BinInt installed.

I reclassified the dependencies according to the code and META.json.
Old spec had some optional dependencies as alwayes required. But these
was many years old without any explanation, so I removed them. If This
breaks user's expectations we can put them back.

diff --git a/perl-Devel-Cover.spec b/perl-Devel-Cover.spec
index e3ede13..93da2b8 100644
--- a/perl-Devel-Cover.spec
+++ b/perl-Devel-Cover.spec
@@ -1,50 +1,83 @@
 Name:           perl-Devel-Cover
 Version:        1.20
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Code coverage metrics for Perl
 Group:          Development/Libraries
 License:        GPL+ or Artistic
 URL:            http://search.cpan.org/dist/Devel-Cover/
 Source0:        http://www.cpan.org/authors/id/P/PJ/PJCJ/Devel-Cover-%{version}.tar.gz
-BuildRequires:  perl(autodie)
-BuildRequires:  perl(base)
+BuildRequires:  coreutils
+BuildRequires:  findutils
+BuildRequires:  make
+BuildRequires:  perl
+BuildRequires:  perl(Cwd)
+BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(File::Copy)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
+# Run-time:
+BuildRequires:  perl(B)
+BuildRequires:  perl(B::Concise)
 BuildRequires:  perl(B::Debug)
-BuildRequires:  perl(Browser::Open)
+BuildRequires:  perl(B::Deparse)
+BuildRequires:  perl(base)
 BuildRequires:  perl(Carp)
-BuildRequires:  perl(HTML::Entities)
-BuildRequires:  perl(Cwd)
+BuildRequires:  perl(Class::XSAccessor)
+BuildRequires:  perl(Config)
+BuildRequires:  perl(constant)
+# CPAN::Releases::Latest not used at tests
 BuildRequires:  perl(Data::Dumper)
 BuildRequires:  perl(Digest::MD5)
 BuildRequires:  perl(DynaLoader)
 BuildRequires:  perl(Exporter)
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(Fcntl)
+BuildRequires:  perl(File::Find)
 BuildRequires:  perl(File::Path)
 BuildRequires:  perl(File::Spec)
-BuildRequires:  perl(JSON::PP)
-BuildRequires:  perl(Template) >= 2.00
-BuildRequires:  perl(PPI::HTML) >= 1.07
+BuildRequires:  perl(Getopt::Long)
+BuildRequires:  perl(HTML::Entities)
+# JSON or JSON::PP by Devel::Cover::DB::IO::JSON
+BuildRequires:  perl(JSON)
+BuildRequires:  perl(Moo)
+BuildRequires:  perl(namespace::clean)
 BuildRequires:  perl(Parallel::Iterator)
-BuildRequires:  perl(Perl::Tidy) >= 20060719
-BuildRequires:  perl(Pod::Coverage) >= 0.06
-BuildRequires:  perl(Pod::Coverage::CountParents)
 BuildRequires:  perl(Pod::Usage)
-BuildRequires:  perl(PPI::HTML) >= 1.07
+BuildRequires:  perl(POSIX)
+BuildRequires:  perl(Sereal::Decoder)
+BuildRequires:  perl(Sereal::Encoder)
+BuildRequires:  perl(Storable)
+BuildRequires:  perl(Template) >= 2.00
 BuildRequires:  perl(Template::Provider)
 BuildRequires:  perl(Test)
+BuildRequires:  perl(Time::HiRes)
+BuildRequires:  perl(vars)
+# Optional run-time:
+# Browser::Open not used at tests
+# (PPI && PPI::HTML 1.07) || Perl::Tidy 20060719
+# Perl::Tidy 20060719 not used at tests
+BuildRequires:  perl(Pod::Coverage) >= 0.06
+BuildRequires:  perl(Pod::Coverage::CountParents)
+# PPI::HTML 1.07 not used at tests 
 BuildRequires:  perl(Test::Differences)
+# Tests:
+BuildRequires:  perl(DBM::Deep)
+BuildRequires:  perl(lib)
+BuildRequires:  perl(Math::BigInt)
+BuildRequires:  perl(Moose)
+BuildRequires:  perl(overload)
+BuildRequires:  perl(Readonly)
 BuildRequires:  perl(Test::More)
-BuildRequires:  perl(ExtUtils::MakeMaker)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-Requires:       perl(Pod::Coverage)
-Requires:       perl(Test::Differences)
-# Optional modules
-# Requires:       perl(PPI::HTML) >= 1.07
-# Requires:       perl(Perl::Tidy) >= 20060719
+# CPAN::Releases::Latest not yet packaged
+# JSON or JSON::PP by Devel::Cover::DB::IO::JSON
+Requires:       perl(JSON)
 
 %{?perl_default_filter}
 
 # Filter private modules
 %global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(Devel::Cover::Dumper\\)
+# Fiter under-specified dependencies
+%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(Template\\)$
 
 %description
 This module provides code coverage metrics for Perl. Code coverage metrics
@@ -82,6 +115,9 @@ make test
 %{_mandir}/man3/*.3pm*
 
 %changelog
+* Wed Jul 22 2015 Petr Pisar <ppisar at redhat.com> - 1.20-2
+- Specify all dependencies
+
 * Mon Jul  6 2015 Tom Callaway <spot at fedoraproject.org> - 1.20-1
 - update to 1.20
 
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/perl-Devel-Cover.git/commit/?h=f23&id=92a47735129646bb15c056aa9641f80968bd8346


More information about the perl-devel mailing list