Review Request 46: New admin interface and builds support

[Ilgiz Islamgulov]

> On Aug. 23, 2013, 6:05 a.m., Tim Flink wrote:
> > blockerbugs/models/spin.py, line 94
> > <http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=939#file939line94>
> >
> >     is there a reason for this change in method name and double to single quotes?

As for me str is better choice for this behaviour.


> On Aug. 23, 2013, 6:05 a.m., Tim Flink wrote:
> > sass/admin_layout.scss, line 1
> > <http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=951#file951line1>
> >
> >     this needs to be compiled and the resultant css added to the patch.
> >     
> >     Is there a reason that this couldn't be added to the main css? Are there conflicts in the flask-admin stuff?

got it, thank you


- Ilgiz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review76
-----------------------------------------------------------


On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 7:01 p.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> Implement new admin interface with flask-admin
> Add build support
> 
> 
> Diffs
> -----
> 
>   testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> 
> 
> Testing
> -------
> 
> I've tested on my develop instance.
> 
> 
> Thanks,
> 
> Ilgiz Islamgulov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130823/f39179b8/attachment.html>