Review Request 31: Display flash messages in appropriate place

Tim Flink fedoraqa.devel at gmail.com
Wed Jul 3 04:25:29 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/31/#review37
-----------------------------------------------------------


Looks simple enough to me - did we really have no places to display flashed messages? How much testing did you do on this? If you've tested it, close the bug and merge to devel

- Tim Flink


On July 1, 2013, 9:40 a.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/31/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 9:40 a.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Bugs: 367
>     https://fedorahosted.org/fedora-qa/ticket/367
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> This patch adds ability to display all flash messages in one common place, under the main menu bar.
> 
> 
> Diffs
> -----
> 
>   blockerbugs/templates/layout.html 28c22872b716d7125880710db53881a73bc8cdc8 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/31/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130703/f6feaab8/attachment.html>


More information about the qa-devel mailing list