Review Request 39: Migrate from FAS to FAS-OpenID

Tim Flink fedoraqa.devel at gmail.com
Wed Jul 17 05:19:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/39/#review43
-----------------------------------------------------------


Don't python-openid-cla and python-openid-teams need to be added to the requirements.txt file? Does the python-fedora stuff really need to be added to site-packages by hand with the bump in required python fedora version?

What all of that list is going to be required above and beyond the changes shown here? I'm not crazy about the idea of releasing like that but I'm suspecting that most of it would go away once a new python-fedora release is done

- Tim Flink


On July 16, 2013, 12:43 p.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/39/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 12:43 p.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Bugs: 383
>     https://fedorahosted.org/fedora-qa/ticket/383
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> commit 211eafe3e90012dce2e99e0fb2f89fbb900062b7
> Author: Patrick Uiterwijk <puiterwijk at gmail.com>
> Date:   Thu May 2 10:33:05 2013 +0200
> 
>     Port blockerbugs to OpenID
> 
> 
> Diffs
> -----
> 
>   requirements.txt e5aeb0dfeeadb5637ddd7f6aafd9fe07ef576c23 
>   blockerbugs/templates/login.html 6023c25e3436257c1c6a1027a9b37ec21f62cee9 
>   blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
>   blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/39/diff/
> 
> 
> Testing
> -------
> 
> To make this work, following things need to be done:
> 
> wget https://raw.github.com/fedora-infra/python-fedora/develop/flask_fas_openid.py
> # apply http://mkrizek.fedorapeople.org/0001-flask_fas_openid.py-fix-imports.patch (sent to Patrick Uiterwijk)
> cp flask_fas_openid.py site-packages
> pip install python-openid-cla
> pip install python-openid-teams
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130717/e6056dd7/attachment.html>


More information about the qa-devel mailing list