Review Request 37: Fix sequences in alembic

Tim Flink fedoraqa.devel at gmail.com
Wed Jul 24 05:56:45 UTC 2013



> On July 17, 2013, 2:45 p.m., Tim Flink wrote:
> > Looks good to me, what all are we going to need to run on stg and production?
> 
> Martin Krizek wrote:
>     I don't think we need to run this on existing installations. To me, this is rather to prevent alembic upgrade/downgrade crashing on new installations.

OK, how have you tested this so far? I assume in your dev env. If you've tested this with postgres, get it merged into develop


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/37/#review45
-----------------------------------------------------------


On July 16, 2013, 12:43 p.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/37/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 12:43 p.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> commit abf5fe2abbcfbce45d103864f5ba40fc89f233fa
> Author: Martin Krizek <mkrizek at redhat.com>
> Date:   Tue Jul 16 13:57:28 2013 +0200
> 
>     Fix sequences in alembic
>     
>     Sequences need to be created separately. The patch also fixes a few
>     typos.
> 
> https://bitbucket.org/zzzeek/alembic/issue/73/more-pg-nextval-it-needs-the-text-wrapper
> 
> 
> Diffs
> -----
> 
>   alembic/versions/487cb8ccce92_dropping_flask_login.py e64dacb2e3b1a3d14bf38e1116df183ded9793d9 
>   alembic/versions/1d12b74d12bd_add_userinfo_table.py 86dc390ed5e49b0a3ca058e163bc02b070d3d294 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/37/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130724/7be0f04c/attachment.html>


More information about the qa-devel mailing list