Review Request 48: Fix FAS openid auth

Ilgiz Islamgulov fedoraqa.devel at gmail.com
Wed Sep 4 19:06:29 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/48/
-----------------------------------------------------------

Review request for blockerbugs.


Repository: blockerbugs


Description
-------

Use "local" for request g.fas_user instead of global auth to store user information.


Diffs
-----

  blockerbugs/util/login.py 0357ed9320b1493ee68a1e2491d99fafa4654b26 
  blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 

Diff: http://reviewboard-tflink.rhcloud.com/r/48/diff/


Testing
-------

Latest https://raw.github.com/fedora-infra/python-fedora/develop/flask_fas_openid.py must be used.

I've tested on my local dev instance.
1) login in browser
2) open blockerbugs in another browser

Login\Logout with dev login.


Thanks,

Ilgiz Islamgulov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130904/566a1b9f/attachment.html>


More information about the qa-devel mailing list