Review Request 52: Clean leftovers missed in reviews

Martin Krizek fedoraqa.devel at gmail.com
Fri Sep 20 09:46:41 UTC 2013



> On Sept. 19, 2013, 7:47 p.m., Tim Flink wrote:
> > I'm OK with removing the --logfile option from the CLI parser but let's hold off on the user changes since ilgiz has already addressed those issues. I'd rather not be fixing that in multiple places at the same time - it's a great recipe for confusion and merge issues

I remove the --logfile option and unused import, it's in develop. I commented on the rest in the diff...


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/#review96
-----------------------------------------------------------


On Sept. 13, 2013, 11:08 a.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/52/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 11:08 a.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> While going through documentation and commits since last release I found some leftovers missed in reviews.
> 
> 
> Diffs
> -----
> 
>   blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
>   blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/52/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130920/070db864/attachment.html>


More information about the qa-devel mailing list