[Fedora Release Engineering] #719: Half-bug: the SHA1SUM files are generated in text mode (instead of binary)

[Fedora Release Engineering]

#719: Half-bug: the SHA1SUM files are generated in text mode (instead of binary)
----------------------------------------------------------+-----------------
  Reporter:  Роман Донченко         <DXDragon at yandex.ru>  |       Owner:  rel-eng at lists.fedoraproject.org
      Type:  task                                         |      Status:  closed                         
 Milestone:                                               |   Component:  koji                           
Resolution:  fixed                                        |    Keywords:                                 
----------------------------------------------------------+-----------------
Comment (by Роман Донченко):

 > We open the file in binary mode so that the hash returned by the sum
 generator should have a *.

 How is that relevant? Since we feed hashlib the strings, not the file
 itself, it has no idea about modes. However, we output the digest as
 "hash<space><space>filename", which means "text mode hash". Binary is
 "hash<space><asterisk>filename".

-- 
Ticket URL: <https://fedorahosted.org/rel-eng/ticket/719#comment:7>
Fedora Release Engineering <http://fedorahosted.org/rel-eng>
Release Engineering for the Fedora Project